From: Jan Kara Subject: Re: [PATCH 07/21] fs: Mark function as static in ext2/xattr_security.c Date: Tue, 11 Feb 2014 21:48:47 +0100 Message-ID: <20140211204847.GC22835@quack.suse.cz> References: <5db9dc03c6c316665e9fd1c6253e9c29ab3a39cf.1391949868.git.rashika.kheria@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: linux-kernel@vger.kernel.org, Jan Kara , linux-ext4@vger.kernel.org, josh@joshtriplett.org To: Rashika Kheria Return-path: Content-Disposition: inline In-Reply-To: <5db9dc03c6c316665e9fd1c6253e9c29ab3a39cf.1391949868.git.rashika.kheria@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-ext4.vger.kernel.org On Sun 09-02-14 18:34:10, Rashika Kheria wrote: > Mark function as static in ext2/xattr_security.c because it is not > used outside this file. >=20 > This also elimiantes the following warning in ext2/xattr_security.c: > fs/ext2/xattr_security.c:45:5: warning: no previous prototype for =E2= =80=98ext2_initxattrs=E2=80=99 [-Wmissing-prototypes] >=20 > Signed-off-by: Rashika Kheria > Reviewed-by: Josh Triplett Thanks. I've merged the patch. Honza > --- > fs/ext2/xattr_security.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/fs/ext2/xattr_security.c b/fs/ext2/xattr_security.c > index cfedb2c..c0ebc4d 100644 > --- a/fs/ext2/xattr_security.c > +++ b/fs/ext2/xattr_security.c > @@ -42,8 +42,8 @@ ext2_xattr_security_set(struct dentry *dentry, cons= t char *name, > value, size, flags); > } > =20 > -int ext2_initxattrs(struct inode *inode, const struct xattr *xattr_a= rray, > - void *fs_info) > +static int ext2_initxattrs(struct inode *inode, const struct xattr *= xattr_array, > + void *fs_info) > { > const struct xattr *xattr; > int err =3D 0; > --=20 > 1.7.9.5 >=20 --=20 Jan Kara SUSE Labs, CR