From: Jan Kara Subject: Re: [PATCH 08/21] fs: Mark function as static in ext3/dir.c Date: Tue, 11 Feb 2014 21:49:01 +0100 Message-ID: <20140211204901.GD22835@quack.suse.cz> References: <999693f220bb65e2a07c4450548d99ea3ceac9d2.1391949868.git.rashika.kheria@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: linux-kernel@vger.kernel.org, Jan Kara , Andrew Morton , Andreas Dilger , linux-ext4@vger.kernel.org, josh@joshtriplett.org To: Rashika Kheria Return-path: Content-Disposition: inline In-Reply-To: <999693f220bb65e2a07c4450548d99ea3ceac9d2.1391949868.git.rashika.kheria@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-ext4.vger.kernel.org On Sun 09-02-14 18:36:27, Rashika Kheria wrote: > Mark function as static in ext3/dir.c because it is not used outside > this file. >=20 > This also eliminates the following warning in ext3/dir.c: > fs/ext3/dir.c:278:8: warning: no previous prototype for =E2=80=98ext3= _dir_llseek=E2=80=99 [-Wmissing-prototypes] >=20 > Signed-off-by: Rashika Kheria > Reviewed-by: Josh Triplett Thanks. I've merged the patch. Honza > --- > fs/ext3/dir.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/fs/ext3/dir.c b/fs/ext3/dir.c > index e66e480..17742ee 100644 > --- a/fs/ext3/dir.c > +++ b/fs/ext3/dir.c > @@ -275,7 +275,7 @@ static inline loff_t ext3_get_htree_eof(struct fi= le *filp) > * NOTE: offsets obtained *before* ext3_set_inode_flag(dir, EXT3_INO= DE_INDEX) > * will be invalid once the directory was converted into a dx = directory > */ > -loff_t ext3_dir_llseek(struct file *file, loff_t offset, int whence) > +static loff_t ext3_dir_llseek(struct file *file, loff_t offset, int = whence) > { > struct inode *inode =3D file->f_mapping->host; > int dx_dir =3D is_dx_dir(inode); > --=20 > 1.7.9.5 >=20 --=20 Jan Kara SUSE Labs, CR