From: =?ISO-8859-15?Q?Luk=E1=A8_Czerner?= Subject: Re: [PATCH 0/6][RFC] Introduce FALLOC_FL_ZERO_RANGE flag for fallocate Date: Mon, 24 Feb 2014 14:47:10 +0100 (CET) Message-ID: References: <1392649703-10772-1-git-send-email-lczerner@redhat.com> <20140224010714.GI4317@dastard> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: linux-ext4@vger.kernel.org, tytso@mit.edu, linux-fsdevel@vger.kernel.org, xfs@oss.sgi.com To: Dave Chinner Return-path: Received: from mx1.redhat.com ([209.132.183.28]:52344 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752399AbaBXNrS (ORCPT ); Mon, 24 Feb 2014 08:47:18 -0500 In-Reply-To: <20140224010714.GI4317@dastard> Sender: linux-ext4-owner@vger.kernel.org List-ID: On Mon, 24 Feb 2014, Dave Chinner wrote: > Date: Mon, 24 Feb 2014 12:07:14 +1100 > From: Dave Chinner > To: Lukas Czerner > Cc: linux-ext4@vger.kernel.org, tytso@mit.edu, linux-fsdevel@vger.kernel.org, > xfs@oss.sgi.com > Subject: Re: [PATCH 0/6][RFC] Introduce FALLOC_FL_ZERO_RANGE flag for > fallocate > > On Mon, Feb 17, 2014 at 04:08:17PM +0100, Lukas Czerner wrote: > > Introduce new FALLOC_FL_ZERO_RANGE flag for fallocate. This has the same > > functionality as xfs ioctl XFS_IOC_ZERO_RANGE. > > > > It can be used to convert a range of file to zeros preferably without > > issuing data IO. Blocks should be preallocated for the regions that span > > holes in the file, and the entire range is preferable converted to > > unwritten extents - even though file system may choose to zero out the > > extent or do whatever which will result in reading zeros from the range > > while the range remains allocated for the file. > > > > This can be also used to preallocate blocks past EOF in the same way as > > with fallocate. Flag FALLOC_FL_KEEP_SIZE which should cause the inode > > size to remain the same. > > > > You can test this feature yourself using xfstests, of fallocate(1) however > > you'll need patches for util_linux, xfsprogs and xfstests which you > > can find here: > > > > http://people.redhat.com/lczerner/zero_range/ > > > > I'll post the patches after we agree and merge the kernel functionality. > > Lukas, can you post the xfstests and xfs_io changes so that they can > be reviewed? Once I can verify the behaviour is the same as > XFS_IOC_ZERO_RANGE, I'm ahppy to commit the VFS and XFS kernel > changes along with the xfsprogs and xfstests changes like I've just > done for the FALLOC_FL_COLLAPSE_RANGE changes. > > I'd like to get all the changes to the VFS into the XFS tree so that > you can handle the ext4 integration of the two pieces of > functionilty as you and Ted see fit.... > > Cheers, > > Dave. Hi Dave, ok, I'll rebase and resend the whole series with the xfstests and xfsprogs patches as well. Thanks! -Lukas