From: Eric Sandeen <sandeen@sandeen.net>
Subject: Re: [PATCH 6/8] fsstress: translate flags in fiemap_f
Date: Fri, 28 Feb 2014 11:55:11 -0600
Message-ID: <5310CD7F.7090902@sandeen.net>
References: <1393603865-26198-1-git-send-email-lczerner@redhat.com>
	<1393603865-26198-6-git-send-email-lczerner@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Cc: linux-fsdevel@vger.kernel.org, xfs@oss.sgi.com
To: Lukas Czerner <lczerner@redhat.com>, linux-ext4@vger.kernel.org
In-Reply-To: <1393603865-26198-6-git-send-email-lczerner@redhat.com>
Errors-To: xfs-bounces@oss.sgi.com
Sender: xfs-bounces@oss.sgi.com

On 2/28/14, 10:11 AM, Lukas Czerner wrote:
> Translate flags in fiemap_f output to human readable strings.

This looks fine, w/ the caveats about translate_flags that I mentioned
on the earlier patch.

Reviewed-by: Eric Sandeen <sandeen@redhat.com>

> Signed-off-by: Lukas Czerner <lczerner@redhat.com>
> ---
>  ltp/fsstress.c | 17 +++++++++++++++--
>  1 file changed, 15 insertions(+), 2 deletions(-)
> 
> diff --git a/ltp/fsstress.c b/ltp/fsstress.c
> index 24864db..869a8ac 100644
> --- a/ltp/fsstress.c
> +++ b/ltp/fsstress.c
> @@ -2252,6 +2252,18 @@ fdatasync_f(int opno, long r)
>  	free_pathname(&f);
>  	close(fd);
>  }
> +
> +#ifdef HAVE_LINUX_FIEMAP_H
> +struct print_flags fiemap_flags[] = {
> +	{ FIEMAP_FLAG_SYNC, "SYNC"},
> +	{ FIEMAP_FLAG_XATTR, "XATTR"},
> +	{ -1, NULL}
> +};
> +
> +#define translate_fiemap_flags(mode)	\
> +	({translate_flags(mode, "|", fiemap_flags);})
> +#endif
> +
>  void
>  fiemap_f(int opno, long r)
>  {
> @@ -2314,9 +2326,10 @@ fiemap_f(int opno, long r)
>  
>  	e = ioctl(fd, FS_IOC_FIEMAP, (unsigned long)fiemap);
>  	if (v)
> -		printf("%d/%d: ioctl(FIEMAP) %s%s %lld %lld %x %d\n",
> +		printf("%d/%d: ioctl(FIEMAP) %s%s %lld %lld (%s) %d\n",
>  		       procid, opno, f.path, st, (long long)fiemap->fm_start,
> -		       (long long) fiemap->fm_length, fiemap->fm_flags, e);
> +		       (long long) fiemap->fm_length,
> +		       translate_fiemap_flags(fiemap->fm_flags), e);
>  	free(fiemap);
>  	free_pathname(&f);
>  	close(fd);
> 

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs