From: Robert Yang Subject: Re: [PATCH V4 05/11] misc/create_inode.c: copy regular file Date: Fri, 7 Mar 2014 09:24:12 +0800 Message-ID: <53191FBC.4040106@windriver.com> References: <1393661175-459-1-git-send-email-liezhi.yang@windriver.com> <1393661175-459-6-git-send-email-liezhi.yang@windriver.com> <20140306190622.GE9875@birch.djwong.org> <20140306194715.GA30214@thunk.org> <20140306201439.GF9875@birch.djwong.org> <20140306225714.GB30214@thunk.org> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Cc: , To: "Theodore Ts'o" , "Darrick J. Wong" Return-path: Received: from mail.windriver.com ([147.11.1.11]:57183 "EHLO mail.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750924AbaCGBYU (ORCPT ); Thu, 6 Mar 2014 20:24:20 -0500 In-Reply-To: <20140306225714.GB30214@thunk.org> Sender: linux-ext4-owner@vger.kernel.org List-ID: On 03/07/2014 06:57 AM, Theodore Ts'o wrote: > On Thu, Mar 06, 2014 at 12:14:39PM -0800, Darrick J. Wong wrote: >> >> I'm already queuing up a bunch of (more) fixes... there's more weird things I >> didn't notice. Such as, why is current_fs now defined in current_inode.h? >> That really ought to have stayed in debugfs.c, and current_inode.h should have >> 'extern ext2_filsys current_fs;', no? > > Yes, that would be better --- although in the long term we should > probably try to get rid of the global variable and pass in an "fs" > parameter into functions in misc/create_inode.c. > > Since these aren't in a shared library, I wasn't worried that much > about the details of the abstraction interface, but I'm sure there are > some ways that we can improve things. > > BTW, one of my plans for 1.43 is to rename libquota.a to libe2int.a, > and to move things like profile.c, and other files shared between misc > and e2fsck, etc., into an "internal support" library. I suspect > create_inoode.c would be a candidate for moving into this internal > support library. > Hi Ted and Darrick, Thank you very much for the great help, I think that I don't have to submit a fix patch again since Darrick has helped me to fix the problem, please feel free to let me know if there is anything I can do. // Robert > Cheers, > >> ...I'll also respin the patchset I sent out a few days ago. > > Sorry for having you respin the patchset yet again --- although > hopefully it should be easier this time around. I'm trying to be fair > in catching up with th e2fsprogs backlog, and Robert and Zheng's > patches have been outstanding for a long time. Don't worry, yours are > next on the list. :-) > > Cheers, > > - Ted > >