From: a3at.mail@gmail.com Subject: Re: [PATCH] ext4: initialize multi-block allocator before checking block descriptors Date: Sun, 16 Mar 2014 20:17:13 +0400 Message-ID: <20140316161637.GA19885@azat> References: <20140315214029.GA18873@thunk.org> <20140316023841.GA902@thunk.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "open list:EXT4 FILE SYSTEM" To: "Theodore Ts'o" Return-path: Received: from mail-la0-f50.google.com ([209.85.215.50]:61453 "EHLO mail-la0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752187AbaCPQRR (ORCPT ); Sun, 16 Mar 2014 12:17:17 -0400 Received: by mail-la0-f50.google.com with SMTP id y1so3100331lam.9 for ; Sun, 16 Mar 2014 09:17:15 -0700 (PDT) Content-Disposition: inline In-Reply-To: Sender: linux-ext4-owner@vger.kernel.org List-ID: On Sun, Mar 16, 2014 at 06:10:12PM +0400, Azat Khuzhin wrote: > On Sun, Mar 16, 2014 at 6:38 AM, wrote: > > On Sun, Mar 16, 2014 at 03:54:34AM +0400, Azat Khuzhin wrote: > >> > >> Thanks Ted, I'll take a look. > >> Are you talking about xfs-tests failures? > > > > Yes, the kernel is complaining that the file system looks corrupt. > > The xfstest generic/001 is the easist one to trigger it: > > > > generic/001 18s ... [17:35:49][ 26.793766] EXT4-fs error (device vde): ext4_mb_generate_buddy:756: group 1, 32763 clusters in bitmap, 32764 > > in gd; block bitmap corrupt. > > [17:36:09] 20s > > [ 39.636943] EXT4-fs (vde): warning: mounting fs with errors, running e2fsck is recommended > > > > I this was using a freshly generated file system using a 20 GiB test > > partition, formatted using: > > > > mke2fs -t ext4 -O bigalloc /dev/vde > > > > Dropping the patch made the error go away. > > Hi Ted, > > I just checked with the last upstream commit d8ec26d7f8287 + patch, > and xfs tests haven't fallen > I even update xfstests, still nothing. > > /src/xfstests # git describe > linux-v3.8-336-g3948694 > > /src/xfstests # ./run_generic.sh > mke2fs 1.42.8 (20-Jun-2013) > /dev/sdb1 is mounted; will not make a filesystem here! > FSTYP -- ext4 > PLATFORM -- Linux/x86_64 debian-virtual-2-6-39 3.13.0+ > MKFS_OPTIONS -- /dev/sdc1 > MOUNT_OPTIONS -- -O bigalloc /dev/sdc1 /xfs-playground/scratch > > generic/001 2s ... 2s > Ran: generic/001 > Passed all 1 tests > > # uname -r > 3.13.0+ > > Maybe I need more recent kernel? I've also tested on 3.14.0-rc6+: a4ecdf8 ("Merge branch 'x86-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip") And no complaints from xfs-tests, and no errors in dmesg. Could you give me more information about you playground? > > > > > Cheers, > > > > - Ted > > > > -- > Respectfully > Azat Khuzhin -- Respectfully Azat Khuzhin