From: "H. Peter Anvin" Subject: Re: [GIT PULL] ext4 changes for 3.15 Date: Wed, 09 Apr 2014 12:19:52 -0700 Message-ID: <7cc6f198-832f-4af7-82ea-2b89ad737885@email.android.com> References: <20140404134429.GB26806@quack.suse.cz> <20140404234358.GE10275@thunk.org> <20140407140745.GA8855@thunk.org> <20140408134740.GB28822@thunk.org> <53457B80.1080307@zytor.com> <20140409182324.GA778@thunk.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Arnd Bergmann , Sam Ravnborg , linux-kbuild , Miklos Szeredi , Jan Kara , Linus Torvalds , Linux Kernel Mailing List , "linux-ext4@vger.kernel.org" , Al Viro , "Michael Kerrisk (man-pages)" To: "Theodore Ts'o" , Geert Uytterhoeven Return-path: Received: from terminus.zytor.com ([198.137.202.10]:49449 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933143AbaDITV4 (ORCPT ); Wed, 9 Apr 2014 15:21:56 -0400 In-Reply-To: <20140409182324.GA778@thunk.org> Sender: linux-ext4-owner@vger.kernel.org List-ID: It is quite frankly ridiculous how much work it takes to wire up a new system call. It should be possible to do it across architectures without all this crap. On April 9, 2014 11:23:24 AM PDT, Theodore Ts'o wrote: >On Wed, Apr 09, 2014 at 07:48:32PM +0200, Geert Uytterhoeven wrote: >> > >> > I'm missing context here, but as an x86 maintainer I have no >intention >> > of allowing system calls that aren't x86-specific to be added to >x86-64 >> > only. >> >> commit 520c8b16505236fc82daa352e6c5e73cd9870cff >> Author: Miklos Szeredi >> Date: Tue Apr 1 17:08:42 2014 +0200 >> >> vfs: add renameat2 syscall >> >> It was added to arch/x86/syscalls/syscall_64.tbl only. > >To be fair, part of the problem is that we don't have good >documentation about best practices in what people should do if adding >new system calls. (i.e., creating a man page and pulling in Michael >Kerrisk, adding tests, wiring up both x86_64 and i386, sending mail to >linux-arch, the scripts/checksyscalls.sh script, etc.) > >I'll confess to being ignorant about the checksyscalls.sh script, and >while I had known about the existence of the linux-arch list, I had >forgotten about it, so if I had tried to add a new system call, it's >likely I would have missed at one or more of these steps. > > - Ted > > > > >> >> Gr{oetje,eeting}s, >> >> Geert >> >> -- >> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- >geert@linux-m68k.org >> >> In personal conversations with technical people, I call myself a >hacker. But >> when I'm talking to journalists I just say "programmer" or something >like that. >> -- Linus Torvalds -- Sent from my mobile phone. Please pardon brevity and lack of formatting.