From: Theodore Ts'o Subject: Re: [PATCH 3/3] mke2fs: check for a partition table and warn if present Date: Mon, 5 May 2014 10:20:56 -0400 Message-ID: <20140505142056.GE22287@thunk.org> References: <1399295044-24489-1-git-send-email-tytso@mit.edu> <1399295044-24489-3-git-send-email-tytso@mit.edu> <20140505135804.GC22287@thunk.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Ext4 Developers List To: =?utf-8?B?THVrw6HFoQ==?= Czerner Return-path: Received: from imap.thunk.org ([74.207.234.97]:49832 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932752AbaEEOU7 (ORCPT ); Mon, 5 May 2014 10:20:59 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-ext4-owner@vger.kernel.org List-ID: On Mon, May 05, 2014 at 04:11:41PM +0200, Luk=C3=A1=C5=A1 Czerner wrote= : >=20 > Fair enough. But we should still make the use of system libblkid by > default if you do not have any objections. What I want to do is test to see if there is a system libblkid available at all, and if so, use it by default. I want to be able to use the internal libblkid for development testing purposes, but the goal is that when Andreas builds on MacOS, it should use the internal libblkid by default (since there is no system blkid), but on Linux systems, we should use the system blkid by default in the 1.43 branch. > Also it'll be great to mention that in the commit description that > this is the reason why we still try to use the old approach. =46air enough. Actually, we should probably put it in the code comments. > blkid_probe_enable_superblocks(pr, 0); Ok, thanks. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html