From: Aditya Kali Subject: Re: [PATCH 9/9] quota: remove warning message that we have fixed the nasty quota bugs Date: Tue, 13 May 2014 00:32:30 -0700 Message-ID: References: <1399782773-20029-1-git-send-email-tytso@mit.edu> <1399782773-20029-10-git-send-email-tytso@mit.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: Ext4 Developers List To: "Theodore Ts'o" Return-path: Received: from mail-ob0-f177.google.com ([209.85.214.177]:46112 "EHLO mail-ob0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753172AbaEMHcw (ORCPT ); Tue, 13 May 2014 03:32:52 -0400 Received: by mail-ob0-f177.google.com with SMTP id wp4so441551obc.8 for ; Tue, 13 May 2014 00:32:51 -0700 (PDT) In-Reply-To: <1399782773-20029-10-git-send-email-tytso@mit.edu> Sender: linux-ext4-owner@vger.kernel.org List-ID: On Sat, May 10, 2014 at 9:32 PM, Theodore Ts'o wrote: > We no longer need to reference https://ext4.wiki.kernel.org/index.php/Quota > since we've fixed the nasty bugs associated with e2fsck and the quota > feature. The wiki page will be updated once we've done a release that > includes these fixes indicated the verison which these problems have > been fixed. > > Signed-off-by: "Theodore Ts'o" > Cc: adityakali@google.com Reviewed-by: Aditya Kali Thanks! > --- > misc/ext4.5.in | 7 ------- > misc/mke2fs.c | 7 ------- > misc/tune2fs.c | 4 ---- > tests/m_quota/expect.1 | 4 ---- > 4 files changed, 22 deletions(-) > > diff --git a/misc/ext4.5.in b/misc/ext4.5.in > index 5ec39f5..134c19f 100644 > --- a/misc/ext4.5.in > +++ b/misc/ext4.5.in > @@ -210,13 +210,6 @@ shared storage environments. > @QUOTA_MAN_COMMENT@Causes the quota files (i.e., user.quota and > @QUOTA_MAN_COMMENT@group.quota which existed > @QUOTA_MAN_COMMENT@in the older quota design) to be hidden inodes. > -@QUOTA_MAN_COMMENT@.IP > -@QUOTA_MAN_COMMENT@.B Warning: > -@QUOTA_MAN_COMMENT@The quota feature is still under development, > -@QUOTA_MAN_COMMENT@and may not be fully supported with your kernel > -@QUOTA_MAN_COMMENT@or may have various bugs. Please > -@QUOTA_MAN_COMMENT@see https://ext4.wiki.kernel.org/index.php/Quota > -@QUOTA_MAN_COMMENT@for more details. > .TP > .B resize_inode > .br > diff --git a/misc/mke2fs.c b/misc/mke2fs.c > index e1fd40e..9c4b0b2 100644 > --- a/misc/mke2fs.c > +++ b/misc/mke2fs.c > @@ -2162,13 +2162,6 @@ profile_error: > "See https://ext4.wiki.kernel.org/" > "index.php/Bigalloc for more information\n\n")); > > - if (!quiet && > - (fs_param.s_feature_ro_compat & EXT4_FEATURE_RO_COMPAT_QUOTA)) > - fprintf(stderr, "%s", _("\nWarning: the quota feature is " > - "still under development\n" > - "See https://ext4.wiki.kernel.org/" > - "index.php/Quota for more information\n\n")); > - > /* Since sparse_super is the default, we would only have a problem > * here if it was explicitly disabled. > */ > diff --git a/misc/tune2fs.c b/misc/tune2fs.c > index 37f0b56..9ba32a1 100644 > --- a/misc/tune2fs.c > +++ b/misc/tune2fs.c > @@ -776,10 +776,6 @@ static void handle_quota_options(ext2_filsys fs) > quota_release_context(&qctx); > > if ((usrquota == QOPT_ENABLE) || (grpquota == QOPT_ENABLE)) { > - fprintf(stderr, "%s", _("\nWarning: the quota feature is still " > - "under development\n" > - "See https://ext4.wiki.kernel.org/" > - "index.php/Quota for more information\n\n")); > fs->super->s_feature_ro_compat |= EXT4_FEATURE_RO_COMPAT_QUOTA; > ext2fs_mark_super_dirty(fs); > } else if (!fs->super->s_usr_quota_inum && > diff --git a/tests/m_quota/expect.1 b/tests/m_quota/expect.1 > index a0f6501..787871c 100644 > --- a/tests/m_quota/expect.1 > +++ b/tests/m_quota/expect.1 > @@ -1,7 +1,3 @@ > - > -Warning: the quota feature is still under development > -See https://ext4.wiki.kernel.org/index.php/Quota for more information > - > Creating filesystem with 131072 1k blocks and 32768 inodes > Superblock backups stored on blocks: > 8193, 24577, 40961, 57345, 73729 > -- > 1.9.0 > -- Aditya