From: Niu Yawei Subject: [PATCH 2/3 v2] quota: avoid unnecessary dqget()/dqput() calls Date: Wed, 28 May 2014 09:53:39 +0800 Message-ID: <538541A3.2060102@gmail.com> References: <537DD5BA.1050105@gmail.com> <538464AD.6050407@gmail.com> <20140527101219.GA28035@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, yawei.niu@intel.com, andreas.dilger@intel.com, lai.siyao@intel.com To: Christoph Hellwig , jack@suse.cz Return-path: Received: from mail-pb0-f43.google.com ([209.85.160.43]:39538 "EHLO mail-pb0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752121AbaE1Bxc (ORCPT ); Tue, 27 May 2014 21:53:32 -0400 In-Reply-To: <20140527101219.GA28035@infradead.org> Sender: linux-ext4-owner@vger.kernel.org List-ID: Avoid unnecessary dqget()/dqput() calls in __dquot_initialize(), that will introduce global lock contention otherwise. Signed-off-by: Lai Siyao Signed-off-by: Niu Yawei --- fs/quota/dquot.c | 13 ++++++++++++- 1 files changed, 12 insertions(+), 1 deletions(-) diff --git a/fs/quota/dquot.c b/fs/quota/dquot.c index 9cd5f63..dc6f711 100644 --- a/fs/quota/dquot.c +++ b/fs/quota/dquot.c @@ -1400,7 +1400,7 @@ static int dquot_active(const struct inode *inode) */ static void __dquot_initialize(struct inode *inode, int type) { - int cnt; + int cnt, dq_get = 0; struct dquot *got[MAXQUOTAS]; struct super_block *sb = inode->i_sb; qsize_t rsv; @@ -1416,6 +1416,13 @@ static void __dquot_initialize(struct inode *inode, int type) got[cnt] = NULL; if (type != -1 && cnt != type) continue; + /* the i_dquot should have been initialized in most case, + * we check it without locking here to avoid unnecessary + * dqget()/dqput() calls. */ + if (inode->i_dquot[cnt]) + continue; + dq_get = 1; + switch (cnt) { case USRQUOTA: qid = make_kqid_uid(inode->i_uid); @@ -1427,6 +1434,10 @@ static void __dquot_initialize(struct inode *inode, int type) got[cnt] = dqget(sb, qid); } + /* all required i_dquot has been initialized */ + if (!dq_get) + return; + down_write(&sb_dqopt(sb)->dqptr_sem); if (IS_NOQUOTA(inode)) goto out_err; -- 1.7.1