From: Theodore Ts'o Subject: Re: [PATCH 1/2] jbd2: don't call get_bh() before calling __jbd2_journal_remove_checkpoint() Date: Wed, 3 Sep 2014 13:30:00 -0400 Message-ID: <20140903173000.GH2504@thunk.org> References: <20140902215930.GJ6232@thunk.org> <1409698000-18126-1-git-send-email-tytso@mit.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Ext4 Developers List To: Yuanhan Liu Return-path: Received: from imap.thunk.org ([74.207.234.97]:35524 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932840AbaICRaF (ORCPT ); Wed, 3 Sep 2014 13:30:05 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-ext4-owner@vger.kernel.org List-ID: On Wed, Sep 03, 2014 at 03:48:56PM +0800, Yuanhan Liu wrote: > > * Get our reference so that bh cannot be freed before > > * we unlock it > > */ > > I guess you need remove those comments as well. Good catch, thanks. - Ted