From: Christoph Hellwig Subject: Re: [PATCH] ext4: Fixed styling issues Date: Sun, 7 Sep 2014 08:46:25 -0700 Message-ID: <20140907154625.GA18274@infradead.org> References: <1410093905-15431-1-git-send-email-dbdaniel42@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Daniel Bomar , Theodore Ts'o , adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, LKML To: Richard Weinberger Return-path: Received: from bombadil.infradead.org ([198.137.202.9]:44177 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752437AbaIGPq3 (ORCPT ); Sun, 7 Sep 2014 11:46:29 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-ext4-owner@vger.kernel.org List-ID: On Sun, Sep 07, 2014 at 03:16:22PM +0200, Richard Weinberger wrote: > On Sun, Sep 7, 2014 at 2:45 PM, Daniel Bomar wrote: > > Fixed styling issues as reported by scripts/checkpatch.pl > > > > Signed-off-by: Daniel Bomar > > Please don't run checkpatch.pl on in-kernel files. I don't think it's up to us to tell people what files they should run patches on on.. That doesn't mean that pure style cleanup patches in an area you don't understand are a good idea, so don't send them. This is different when you actually do a major overhaul of an area, in which case I'd actually like to do a first pass of style cleanup and refactoring before submitting the real work.