From: Theodore Ts'o Subject: Re: [PATCH 11/34] dumpe2fs: output cleanup Date: Fri, 19 Sep 2014 12:22:00 -0400 Message-ID: <20140919162200.GO26995@thunk.org> References: <20140913221112.13646.3873.stgit@birch.djwong.org> <20140913221226.13646.37351.stgit@birch.djwong.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-ext4@vger.kernel.org, TR Reardon To: "Darrick J. Wong" Return-path: Received: from imap.thunk.org ([74.207.234.97]:37783 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753398AbaISQWE (ORCPT ); Fri, 19 Sep 2014 12:22:04 -0400 Content-Disposition: inline In-Reply-To: <20140913221226.13646.37351.stgit@birch.djwong.org> Sender: linux-ext4-owner@vger.kernel.org List-ID: On Sat, Sep 13, 2014 at 03:12:26PM -0700, Darrick J. Wong wrote: > Don't display unused inodes twice, and make it clear that we're > printing a descriptor checksum. > > Signed-off-by: Darrick J. Wong > Cc: TR Reardon One problem with the current output format is that exceeds the 80 character line limit pretty blatently: Group 3: (Blocks 24577-32768) [INODE_UNINIT, BLOCK_UNINIT, ITABLE_ZEROED] Checksum 0x5bd9, unused inodes 2048 Backup superblock at 24577, Group descriptors at 24578-24578 Reserved GDT blocks at 24579-24833 Block bitmap at 261 (bg #0 + 260), csum 0x00000000, Inode bitmap at 269 (bg #0 + 268), csum 0x00000000 Inode table at 1042-1297 (bg #0 + 1041) 7935 free blocks, 2048 free inodes, 0 directories, 2048 unused inodes Free blocks: 24834-32768 Free inodes: 6145-8192 If we are printing the checksum, we probably need to insert a line break and indent before printing the Inode bitmap. Does that seem reasonable? - Ted