From: Theodore Ts'o <tytso@mit.edu>
Subject: Re: [PATCH] ext4: fix suboptimal seek_{data,hole} extents traversial
Date: Sat, 29 Nov 2014 12:52:55 -0500
Message-ID: <20141129175255.GC4362@thunk.org>
References: <87egu7k6ym.fsf@openvz.org>
 <1413552334-32240-1-git-send-email-dmonakhov@openvz.org>
 <20141125211433.GB28449@thunk.org>
 <873893id1x.fsf@openvz.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: linux-kernel@vger.kernel.org, linux-ext4@vger.kernel.org
To: Dmitry Monakhov <dmonakhov@openvz.org>
Content-Disposition: inline
In-Reply-To: <873893id1x.fsf@openvz.org>
Sender: linux-ext4-owner@vger.kernel.org

On Fri, Nov 28, 2014 at 06:02:02PM +0300, Dmitry Monakhov wrote:
> FYI: inline_data feature is fatally broken

Thanks for finding the bugs!

> 2) ext4_inline_data_fiemap(0 ignores start and len arguments from ext4_filemap()
>    which obviously result in endless loop for anyone who want to use
>    fiemap for inline files (which my patch try to do)

Would this have been triggered using filefrag?  I just checked and
noticed we don't have a filefrag test in xfstests; of course it would
be impossible to test other than the filefrag -v command successfully
completed, but maybe it might be worth adding such a test.

	       	     	      	       	      	   - Ted