From: Theodore Ts'o <tytso@mit.edu>
Subject: Re: [PATCH] ext4/004: add dump/restore test
Date: Sat, 6 Dec 2014 16:40:40 -0500
Message-ID: <20141206214040.GA27484@thunk.org>
References: <1416910869-28538-1-git-send-email-wangxg.fnst@cn.fujitsu.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: fstests@vger.kernel.org, linux-ext4@vger.kernel.org
To: Xiaoguang Wang <wangxg.fnst@cn.fujitsu.com>
Content-Disposition: inline
In-Reply-To: <1416910869-28538-1-git-send-email-wangxg.fnst@cn.fujitsu.com>
Sender: linux-ext4-owner@vger.kernel.org

On Tue, Nov 25, 2014 at 06:21:09PM +0800, Xiaoguang Wang wrote:
> This test case will first use fsstress to fill a file system, then
> dump it to standard output and restore it from standard input, finally
> check that the original contents and the new contents generated by
> restore tool will be same.
> 
> Signed-off-by: Xiaoguang Wang <wangxg.fnst@cn.fujitsu.com>

One question --- what is the intent of this test?  Is it to test the
kernel, or the dump/restore program?  I have not bothered putting
regression tests for e2fsprogs in xfstests, because if I'm developing
e2fsprogs, it actually makes much more sense to put the regression
tests in the e2fsprogs git tree.

If this is because it's more convenient to put this in xfsprogs
because it has fsstress, maybe we should adjust the groups that it is
in so that it's not in auto or quick, but some other group?  Or add it
to some group like "userspace" so I can exclude it when I'm mostly
interested in testing development kernels?

Thanks,

						- Ted