From: Dave Chinner Subject: Re: [PATCH] ext4/004: add dump/restore test Date: Tue, 16 Dec 2014 14:59:43 +1100 Message-ID: <20141216035942.GE2152@dastard> References: <1416910869-28538-1-git-send-email-wangxg.fnst@cn.fujitsu.com> <20141206214040.GA27484@thunk.org> <54850290.2070201@cn.fujitsu.com> <20141216025827.GO17575@thunk.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Xiaoguang Wang , fstests@vger.kernel.org, linux-ext4@vger.kernel.org To: Theodore Ts'o Return-path: Content-Disposition: inline In-Reply-To: <20141216025827.GO17575@thunk.org> Sender: fstests-owner@vger.kernel.org List-Id: linux-ext4.vger.kernel.org On Mon, Dec 15, 2014 at 09:58:27PM -0500, Theodore Ts'o wrote: > On Mon, Dec 08, 2014 at 09:44:48AM +0800, Xiaoguang Wang wrote: > > > > Yeah, my intent is to test dump/restore program, and indeed I imitate that > > how xfs to test xfsdump/xfsrestore, xfs puts xfsdump/xfsrestore tests in > > corresponding xfs directory. > > I'm finding that the test takes 6-7 minutes to run, partially because > it's writing close to half a gigabyte worth of data for the > dump/restore. Is this really necessary? Can we perhaps cut down the > amount of data generated by running fsstress? Yes, that is too long for an "auto" test. A couple of minutes is about the limit we should be trying to stick to for auto tests; we don't really add any extra coverage by making such tests run for a long time. As it is, most of the xfsdump/restore tests take around 30-60s to run, so that's probably a good guide to follow for this. > And I'll note that using the current fsstress arguments, you are only > creating regular files and directories, and there are no symlinks, > device nodes, or FIFO's being created to test whether those files are > correctly being backed up and restored. Probably a good idea, too. Thanks for looking at this, Ted. Cheers, Dave. -- Dave Chinner david@fromorbit.com