From: Dave Chinner Subject: Re: [PATCH RESEND 1/12] fs: Add support FALLOC_FL_INSERT_RANGE for fallocate Date: Tue, 17 Feb 2015 10:53:47 +1100 Message-ID: <20150216235346.GD4251@dastard> References: <1424101680-3301-1-git-send-email-linkinjeon@gmail.com> <1424101680-3301-2-git-send-email-linkinjeon@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: tytso@mit.edu, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-ext4@vger.kernel.org, xfs@oss.sgi.com, a.sangwan@samsung.com, bfoster@redhat.com, mtk.manpages@gmail.com, linux-man@vger.kernel.org, linux-api@vger.kernel.org, Namjae Jeon To: Namjae Jeon Return-path: Received: from ipmail05.adl6.internode.on.net ([150.101.137.143]:11413 "EHLO ipmail05.adl6.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751038AbbBPXxu (ORCPT ); Mon, 16 Feb 2015 18:53:50 -0500 Content-Disposition: inline In-Reply-To: <1424101680-3301-2-git-send-email-linkinjeon@gmail.com> Sender: linux-ext4-owner@vger.kernel.org List-ID: On Tue, Feb 17, 2015 at 12:47:48AM +0900, Namjae Jeon wrote: > From: Namjae Jeon > > FALLOC_FL_INSERT_RANGE command is the opposite command of > FALLOC_FL_COLLAPSE_RANGE that is needed for advertisers or someone who want to > add some data in the middle of file. FALLOC_FL_INSERT_RANGE will create space > for writing new data within a file after shifting extents to right as given > length. and this command also has same limitation as FALLOC_FL_COLLAPSE_RANGE, > that is block boundary and use ftruncate(2) for crosses EOF. > > Signed-off-by: Namjae Jeon > Signed-off-by: Ashish Sangwan > Cc: Brian Foster > --- > fs/open.c | 8 +++++++- > include/uapi/linux/falloc.h | 17 +++++++++++++++++ > 2 files changed, 24 insertions(+), 1 deletion(-) > > diff --git a/fs/open.c b/fs/open.c > index 813be03..762fb45 100644 > --- a/fs/open.c > +++ b/fs/open.c > @@ -232,7 +232,8 @@ int vfs_fallocate(struct file *file, int mode, loff_t offset, loff_t len) > > /* Return error if mode is not supported */ > if (mode & ~(FALLOC_FL_KEEP_SIZE | FALLOC_FL_PUNCH_HOLE | > - FALLOC_FL_COLLAPSE_RANGE | FALLOC_FL_ZERO_RANGE)) > + FALLOC_FL_COLLAPSE_RANGE | FALLOC_FL_ZERO_RANGE | > + FALLOC_FL_INSERT_RANGE)) > return -EOPNOTSUPP; Can we create a FALLOC_FL_SUPPORTED_MASK define in falloc.h so that we only need to add new flags to the mask in rather than change this code every time we add a new flag? Cheers, Dave. -- Dave Chinner david@fromorbit.com