From: Dave Chinner Subject: Re: [PATCH RESEND 11/12] xfstests: fsx: Add fallocate insert range operation Date: Tue, 17 Feb 2015 12:00:33 +1100 Message-ID: <20150217010033.GG4251@dastard> References: <1424101680-3301-1-git-send-email-linkinjeon@gmail.com> <1424101680-3301-12-git-send-email-linkinjeon@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: tytso@mit.edu, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-ext4@vger.kernel.org, xfs@oss.sgi.com, a.sangwan@samsung.com, bfoster@redhat.com, mtk.manpages@gmail.com, linux-man@vger.kernel.org, linux-api@vger.kernel.org, Namjae Jeon To: Namjae Jeon Return-path: Content-Disposition: inline In-Reply-To: <1424101680-3301-12-git-send-email-linkinjeon@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-ext4.vger.kernel.org On Tue, Feb 17, 2015 at 12:47:58AM +0900, Namjae Jeon wrote: > From: Namjae Jeon > > This commit adds fallocate FALLOC_FL_INSERT_RANGE support for fsx. > > Signed-off-by: Namjae Jeon > Signed-off-by: Ashish Sangwan > Reviewed-by: Brian Foster > --- > ltp/fsx.c | 124 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++----- > 1 file changed, 114 insertions(+), 10 deletions(-) ..... > @@ -339,6 +341,14 @@ logdump(void) > lp->args[0] + lp->args[1]) > prt("\t******CCCC"); > break; > + case OP_INSERT_RANGE: > + prt("INSERT 0x%x thru 0x%x\t(0x%x bytes)", > + lp->args[0], lp->args[0] + lp->args[1] - 1, > + lp->args[1]); > + if (badoff >= lp->args[0] && badoff < > + lp->args[0] + lp->args[1]) > + prt("\t******CCCC"); Probably should output "*****IIII" so we can distinguish it from collapse operations easily. > @@ -1307,6 +1403,9 @@ usage(void) > #ifdef FALLOC_FL_COLLAPSE_RANGE > " -C: Do not use collapse range calls\n" > #endif > +#ifdef FALLOC_FL_INSERT_RANGE > +" -i: Do not use insert range calls\n" > +#endif I'd make that "-I" rather than "-i" so it matches with the "-C" of collapse range. Cheers, Dave. -- Dave Chinner david@fromorbit.com