From: Jan Kara Subject: Re: [v9 1/5] vfs: adds general codes to enforces project quota limits Date: Mon, 16 Mar 2015 15:29:44 +0100 Message-ID: <20150316142944.GN4934@quack.suse.cz> References: <1426043003-31043-1-git-send-email-lixi@ddn.com> <1426043003-31043-2-git-send-email-lixi@ddn.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-api@vger.kernel.org, tytso@mit.edu, adilger@dilger.ca, jack@suse.cz, viro@zeniv.linux.org.uk, hch@infradead.org, dmonakhov@openvz.org, dchinner@redhat.com To: Li Xi Return-path: Content-Disposition: inline In-Reply-To: <1426043003-31043-2-git-send-email-lixi@ddn.com> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-ext4.vger.kernel.org On Wed 11-03-15 12:03:19, Li Xi wrote: > This patch adds support for a new quota type PRJQUOTA for project quota > enforcement. Also a new method get_projid() is added into dquot_operations > structure. > > Signed-off-by: Li Xi > Signed-off-by: Dmitry Monakhov > Reviewed-by: Jan Kara ... > diff --git a/fs/quota/quota.c b/fs/quota/quota.c > index 2aa4151..c76b350 100644 > --- a/fs/quota/quota.c > +++ b/fs/quota/quota.c > @@ -30,11 +30,15 @@ static int check_quotactl_permission(struct super_block *sb, int type, int cmd, > case Q_XGETQSTATV: > case Q_XQUOTASYNC: > break; > - /* allow to query information for dquots we "own" */ > + /* > + * allow to query information for dquots we "own" > + * always allow querying project quota > + */ > case Q_GETQUOTA: > case Q_XGETQUOTA: > if ((type == USRQUOTA && uid_eq(current_euid(), make_kuid(current_user_ns(), id))) || > - (type == GRPQUOTA && in_egroup_p(make_kgid(current_user_ns(), id)))) > + (type == GRPQUOTA && in_egroup_p(make_kgid(current_user_ns(), id))) || > + (type == PRJQUOTA)) > break; I wanted to merge this patch but this hunk caught my eye. Why do we suddently allow querying of project quotas? Traditionally that has been allowed only with CAP_SYS_ADMIN. I agree it looks too restrictive to me but unless that's a bug, I think we have to adhere to original behavior and drop this hunk. Dave, was that behavior of project quotas intended? Honza -- Jan Kara SUSE Labs, CR