From: Eryu Guan Subject: [PATCH v2] shared/289: do not special-case ext3 Date: Mon, 27 Apr 2015 23:51:00 +0800 Message-ID: <1430149860-27321-1-git-send-email-eguan@redhat.com> References: <1430134449-16060-1-git-send-email-eguan@redhat.com> Cc: linux-ext4@vger.kernel.org, Eryu Guan To: fstests@vger.kernel.org Return-path: In-Reply-To: <1430134449-16060-1-git-send-email-eguan@redhat.com> Sender: fstests-owner@vger.kernel.org List-Id: linux-ext4.vger.kernel.org Commit "3574531 xfstests: count journal size in test 289" makes ext3 a special case, but now it's not the case anymore after kernel commit 2046fd1 ext3: Count journal as bsddf overhead in ext3_statfs So just remove the special case, now test passes on both ext3 and ext4, also ext3 driven by ext4 module. Reviewed-by: Eric Sandeen Signed-off-by: Eryu Guan --- v2: - point to right kernel commit id in commit message tests/shared/289 | 13 +------------ 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/tests/shared/289 b/tests/shared/289 index c53d38c..96c949d 100755 --- a/tests/shared/289 +++ b/tests/shared/289 @@ -58,18 +58,7 @@ TOTAL_BLOCKS=`dumpe2fs -h $SCRATCH_DEV 2>/dev/null \ FREE_BLOCKS=`dumpe2fs -h $SCRATCH_DEV 2>/dev/null \ | awk '/Free blocks:/{print $3}'` -# ext3 doesn't count journal blocks as overhead, ext4 does. -if [ $FSTYP = "ext3" ]; then - JOURNAL_SIZE=`dumpe2fs -h $SCRATCH_DEV 2>/dev/null \ - | awk '/Journal size:/{print $3}' | _filter_size_to_bytes` - BLOCK_SIZE=`dumpe2fs -h $SCRATCH_DEV 2>/dev/null \ - | awk '/Block size:/{print $3}'` - JOURNAL_BLOCKS=$(($JOURNAL_SIZE/$BLOCK_SIZE)) -else - JOURNAL_BLOCKS=0 -fi - -OVERHEAD=$(($TOTAL_BLOCKS-$FREE_BLOCKS-$JOURNAL_BLOCKS)) +OVERHEAD=$(($TOTAL_BLOCKS-$FREE_BLOCKS)) # bsddf|minixdf # Set the behaviour for the statfs system call. The minixdf -- 2.1.0