From: Theodore Ts'o Subject: Re: Lazytime undone by/not working with remount? Date: Mon, 18 May 2015 11:23:09 -0400 Message-ID: <20150518152309.GB4180@thunk.org> References: <55575399.6010801@googlemail.com> <20150518082135.GK4834@ws.net.home> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Holger =?iso-8859-1?Q?Hoffst=E4tte?= , linux-ext4@vger.kernel.org To: Karel Zak Return-path: Received: from imap.thunk.org ([74.207.234.97]:42698 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753444AbbERPXZ (ORCPT ); Mon, 18 May 2015 11:23:25 -0400 Content-Disposition: inline In-Reply-To: <20150518082135.GK4834@ws.net.home> Sender: linux-ext4-owner@vger.kernel.org List-ID: On Mon, May 18, 2015 at 10:21:35AM +0200, Karel Zak wrote: > I see the problem on another place. The ext4 fs driver has unique > feature that it's able to accept "lazytime" option as string > (util-linux < 2.26.2) as well as MS_LAZYTIME vfs flag (>= 2.26.2). > > IMHO the function ext4_remount() does not check VFS *flags for > MS_LAZYTIME at all. The code probably cares about sb->s_flags only > (these flags are generated by parse_options() when parse options > string). It seems that only MS_RDONLY is expected in *flags. Yep, the bug is on my side, in ext4_remount(). I'll get this fixed and marked as something that should get bacported to the stable tree. My apologies for the oversight. - Ted