From: =?UTF-8?B?SG9sZ2VyIEhvZmZzdMOkdHRl?= Subject: Re: Lazytime undone by/not working with remount? Date: Mon, 18 May 2015 17:38:27 +0200 Message-ID: <555A0773.9010905@googlemail.com> References: <55575399.6010801@googlemail.com> <20150518082135.GK4834@ws.net.home> <20150518152309.GB4180@thunk.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: linux-ext4@vger.kernel.org To: Theodore Ts'o , Karel Zak Return-path: Received: from static.68.134.40.188.clients.your-server.de ([188.40.134.68]:50494 "EHLO mail02.iobjects.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752704AbbERPsc (ORCPT ); Mon, 18 May 2015 11:48:32 -0400 In-Reply-To: <20150518152309.GB4180@thunk.org> Sender: linux-ext4-owner@vger.kernel.org List-ID: On 05/18/15 17:23, Theodore Ts'o wrote: > On Mon, May 18, 2015 at 10:21:35AM +0200, Karel Zak wrote: >> I see the problem on another place. The ext4 fs driver has unique >> feature that it's able to accept "lazytime" option as string >> (util-linux < 2.26.2) as well as MS_LAZYTIME vfs flag (>= 2.26.2). >> >> IMHO the function ext4_remount() does not check VFS *flags for >> MS_LAZYTIME at all. The code probably cares about sb->s_flags only >> (these flags are generated by parse_options() when parse options >> string). It seems that only MS_RDONLY is expected in *flags. > > Yep, the bug is on my side, in ext4_remount(). I'll get this fixed > and marked as something that should get bacported to the stable tree. > My apologies for the oversight. Thanks for confirming, Ted! I'll gladly test a patch for 4.0.x. -h