From: Alexey Lyashkov Subject: Re: [PATCH 12/19] libext2fs: Bump default number of reserved inodes to 64 Date: Fri, 7 Aug 2015 13:58:22 +0300 Message-ID: References: <1438944689-24562-1-git-send-email-jack@suse.com> <1438944689-24562-13-git-send-email-jack@suse.com> Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2102\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: linux-ext4@vger.kernel.org, Ted Tso , "Darrick J. Wong" , Jan Kara To: Jan Kara Return-path: Received: from mail-pa0-f53.google.com ([209.85.220.53]:34311 "EHLO mail-pa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752881AbbHGK63 convert rfc822-to-8bit (ORCPT ); Fri, 7 Aug 2015 06:58:29 -0400 Received: by pawu10 with SMTP id u10so86449184paw.1 for ; Fri, 07 Aug 2015 03:58:29 -0700 (PDT) In-Reply-To: <1438944689-24562-13-git-send-email-jack@suse.com> Sender: linux-ext4-owner@vger.kernel.org List-ID: May you don=E2=80=99t use a magic constants in code? It hard to maintai= n latter. > On Aug 7, 2015, at 1:51 PM, Jan Kara wrote: >=20 > From: Jan Kara >=20 > We ran out of reserved inodes so bump the default number of reserved > inodes to 64 to get some breathing space. Otherwise we have to do a f= ull > fs scan when increasing number of reserved inodes when some feature > needing another reserved inode is enabled. This consumes 13.5 KB on a > filesystem which is negligible these days. >=20 > Signed-off-by: Jan Kara > --- > lib/ext2fs/initialize.c | 2 +- > misc/mke2fs.8.in | 8 ++++---- > misc/mke2fs.conf.5.in | 7 ++++--- > 3 files changed, 9 insertions(+), 8 deletions(-) >=20 > diff --git a/lib/ext2fs/initialize.c b/lib/ext2fs/initialize.c > index 75fbf8ee0061..0ecf4606ce48 100644 > --- a/lib/ext2fs/initialize.c > +++ b/lib/ext2fs/initialize.c > @@ -186,7 +186,7 @@ errcode_t ext2fs_initialize(const char *name, int= flags, >=20 > set_field(s_rev_level, EXT2_GOOD_OLD_REV); > if (super->s_rev_level >=3D EXT2_DYNAMIC_REV) { > - set_field(s_first_ino, EXT2_GOOD_OLD_FIRST_INO); > + set_field(s_first_ino, 64); > set_field(s_inode_size, EXT2_GOOD_OLD_INODE_SIZE); > if (super->s_inode_size >=3D sizeof(struct ext2_inode_large)) { > int extra_isize =3D sizeof(struct ext2_inode_large) - > diff --git a/misc/mke2fs.8.in b/misc/mke2fs.8.in > index 520a07185f9f..6eef1d97bfbf 100644 > --- a/misc/mke2fs.8.in > +++ b/misc/mke2fs.8.in > @@ -386,10 +386,10 @@ Do not attempt to discard blocks at mkfs time. > @QUOTA_MAN_COMMENT@behavior is to initialize both user and group quot= as. > .TP > .BI reserved_inodes=3D number > -Specify the number of inodes reserved for system files. This number = must be > -at least 10. Currently 10 is enough but future features may require = additional > -reserved inodes. Reserving more inodes after file system is created = requires > -full file system scan so it can take a long time. > +Specify the number of inodes reserved for system files. This number = must be at > +least 10, default is 64. Currently 10 is enough but future features = may require > +additional reserved inodes. Reserving more inodes after file system = is created > +requires full file system scan so it can take a long time. > .RE > .TP > .BI \-f " fragment-size" > diff --git a/misc/mke2fs.conf.5.in b/misc/mke2fs.conf.5.in > index 06ca9e4eabc4..b35767bfedf2 100644 > --- a/misc/mke2fs.conf.5.in > +++ b/misc/mke2fs.conf.5.in > @@ -197,9 +197,10 @@ reserved ratio. This value can be a floating poi= nt number. > .TP > .I reserved_inodes > This relation specifies the default number of inodes reserved for sys= tem files. > -The number must be at least 10. Currently 10 is enough but future fe= atures may > -require additional reserved inodes. Reserving more inodes after file= system is > -created requires full file system scan so it can take a long time. > +The number must be at least 10, default is 64. Currently 10 is enoug= h but > +future features may require additional reserved inodes. Reserving mo= re inodes > +after file system is created requires full file system scan so it ca= n take a > +long time. > .TP > .I undo_dir > This relation specifies the directory where the undo file should be > --=20 > 2.1.4 >=20 > -- > To unsubscribe from this list: send the line "unsubscribe linux-ext4"= in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html