From: Albino B Neto <bino@riseup.net>
Subject: Re: [PATCH] Fix style and return NULL
Date: Mon, 21 Sep 2015 15:24:56 -0300
Message-ID: <CAMu38xJEgUBq0uT5tt3VxUWkKaaFknrUK3wV1Qhe-Z5KtB35Rw@mail.gmail.com>
References: <tytso@mit.edu>
	<1442613662-5100-1-git-send-email-bino@riseup.net>
	<20150919034848.GD2921@thunk.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Cc: linux-ext4@vger.kernel.org
To: "Theodore Ts'o" <tytso@mit.edu>
In-Reply-To: <20150919034848.GD2921@thunk.org>
Sender: linux-ext4-owner@vger.kernel.org

2015-09-19 0:48 GMT-03:00 Theodore Ts'o <tytso@mit.edu>:
> Please don't try to correct "style" --- in fact, you've made things
> worse, and in fact, you've introduced compile errors when tried to fix
> "style".
>
> You also apparently didn't bother to check and see if the patch
> compiled correctly.  Please *do* try to make sure you have (a) tested
> your patches to make sure that they compile, and (b) at the very
> *minimum* tested your patch to make sure that any code paths you have
> changed has been exercised.
>
> In addition, it is highly preferable that for ext4 changes that you
> have tested them using kvm-xfstests[1] or gce-xfstests[2] before
> submitting a patch.  This may seem like a lot of extra work, but
> unlike other parts of the kernel, if you just make the kernel crash,
> it will annoy users --- but if you corrupt their data, they users tend
> to get really steamed, so we have somewhat higher standards in file
> system code.
>
> Of course, if your changes cause the kernel to not even compile, users
> aren't at risk of losing their data; but then you tend to annoy your
> fellow kernel developers.  :-)
>
>
> [1] https://git.kernel.org/cgit/fs/ext2/xfstests-bld.git/plain/quick-start?h=META
> [2] https://git.kernel.org/cgit/fs/ext2/xfstests-bld.git/tree/kvm-xfstests/README.GCE

Thank for help.

  Albino