From: =?UTF-8?Q?Andreas_Gr=C3=BCnbacher?= Subject: Re: [PATCH v8 10/41] richacl: Permission check algorithm Date: Mon, 28 Sep 2015 18:51:47 +0200 Message-ID: References: <1443391772-10171-1-git-send-email-agruenba@redhat.com> <1443391772-10171-11-git-send-email-agruenba@redhat.com> <20150928160855.GD1358@fieldses.org> <20150928162905.GE1358@fieldses.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Andreas Gruenbacher , Alexander Viro , "Theodore Ts'o" , Andreas Dilger , Jeff Layton , Trond Myklebust , Anna Schumaker , linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Linux Kernel Mailing List , Linux FS-devel Mailing List , Linux NFS Mailing List , Linux API Mailing List To: "J. Bruce Fields" Return-path: In-Reply-To: <20150928162905.GE1358-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org> Sender: linux-nfs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-ext4.vger.kernel.org 2015-09-28 18:29 GMT+02:00 J. Bruce Fields : > On Mon, Sep 28, 2015 at 06:25:23PM +0200, Andreas Gr=C3=BCnbacher wro= te: >> 2015-09-28 18:08 GMT+02:00 J. Bruce Fields : >> > The above also skips the following group_mask application on any u= nix >> > group. >> >> Really? How does it do that? > > Sorry, I meant "unix user", not "unix group"! Indeed, that's a bit tricky. Probably worth changing if just for clarit= y: - goto entry_matches_owner; + if (uid_eq(current_fsuid(), inode->i_uid)) + goto entry_matches_owner; Thanks, Andreas -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html