From: Andreas Gruenbacher Subject: Re: [PATCH v10 44/46] nfs: Add richacl support Date: Mon, 12 Oct 2015 21:49:17 +0200 Message-ID: References: <1444604337-17651-1-git-send-email-andreas.gruenbacher@gmail.com> <1444604337-17651-45-git-send-email-andreas.gruenbacher@gmail.com> <561BC61E.6010704@Netapp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: linux-cifs@vger.kernel.org, Linux NFS Mailing List , Theodore Ts'o , Linux API , Andreas Gruenbacher , Trond Myklebust , LKML , xfs@oss.sgi.com, "J. Bruce Fields" , Andreas Dilger , Alexander Viro , linux-fsdevel , Jeff Layton , linux-ext4 To: Anna Schumaker Return-path: In-Reply-To: <561BC61E.6010704@Netapp.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com List-Id: linux-ext4.vger.kernel.org Anna, On Mon, Oct 12, 2015 at 4:39 PM, Anna Schumaker wrote: > I'm not a fan of the "one giant function" approach. Is there any way to split richacl_from_nfs4_acl() into several smaller functions? sure, parsing the usr/group identifier could be put in a separate function, for example. That function cannot stay as it is right now anyway --- we really need idmapper to tell us when an identifier string cannot be mapped to a uid or gid so that we can preserve that identifier. Thanks, Andreas _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs