From: Pranith Kumar Subject: Re: [PATCH] fs: XFS_IOC_FS[SG]SETXATTR to FS_IOC_FS[SG]ETXATTR promotion Date: Fri, 29 Jan 2016 19:56:44 -0500 Message-ID: References: <1442146833-13652-1-git-send-email-lixi@ddn.com> <1442146833-13652-4-git-send-email-lixi@ddn.com> <20160103230534.GE6682@dastard> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Li Xi , "open list:OVERLAYFS FILESYSTEM" , linux-ext4@vger.kernel.org, "open list:KERNEL SELFTEST F..." , "Theodore Ts'o" , adilger@dilger.ca, Jan Kara , Al Viro , hch@infradead.org, dmonakhov@openvz.org To: Dave Chinner Return-path: In-Reply-To: <20160103230534.GE6682@dastard> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-ext4.vger.kernel.org On Sun, Jan 3, 2016 at 6:05 PM, Dave Chinner wrot= e: > On Sun, Sep 13, 2015 at 09:20:32PM +0900, Li Xi wrote: >> This patch adds FS_IOC_FSSETXATTR/FS_IOC_FSGETXATTR ioctl interface >> support for ext4. The interface is kept consistent with >> XFS_IOC_FSGETXATTR/XFS_IOC_FSGETXATTR. >> >> Signed-off-by: Li Xi >> Reviewed-by: Andreas Dilger >> Reviewed-by: Jan Kara > Hello, This commit breaks building latest qemu as follows: In file included from /usr/include/xfs/xfs.h:58:0, from /home/pranith/qemu/block/raw-posix.c:96: /usr/include/xfs/xfs_fs.h:42:8: error: redefinition of =E2=80=98struct = fsxattr=E2=80=99 struct fsxattr { ^ In file included from /home/pranith/qemu/block/raw-posix.c:59:0: /usr/include/linux/fs.h:155:8: note: originally defined here struct fsxattr { ^ /home/pranith/qemu/rules.mak:57: recipe for target 'block/raw-posix.o' = failed I think this is caused by moving the fsxattr struct around. Is the header inclusion messed up somehow? Thanks, --=20 Pranith -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html