From: Ross Zwisler <ross.zwisler@linux.intel.com>
Subject: Re: [PATCH] dax: dirty inode only if required
Date: Thu, 4 Feb 2016 08:50:39 -0700
Message-ID: <20160204155039.GA17818@linux.intel.com>
References: <87k2mkr2ud.fsf@openvz.org>
 <20160204143344.GA6895@quack.suse.cz>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Dmitry Monakhov <dmonakhov@openvz.org>,
	Ross Zwisler <ross.zwisler@linux.intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"H. Peter Anvin" <hpa@zytor.com>,
	"J. Bruce Fields" <bfields@fieldses.org>,
	Theodore Ts'o <tytso@mit.edu>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	Andreas Dilger <adilger.kernel@dilger.ca>,
	Dave Chinner <david@fromorbit.com>,
	Ingo Molnar <mingo@redhat.com>, Jan Kara <jack@suse.com>,
	Jeff Layton <jlayton@poochiereds.net>,
	Matthew Wilcox <willy@linux.intel.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	linux-ext4 <linux-ext4@vger.kernel.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	Linux MM <linux-mm@kvack.org>,
	"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
	X86 ML <x86@kernel.org>, XFS Developers <xfs@oss.sgi.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Matthew Wilcox <matthew.r.wilcox@intel.com>,
	Da
To: Jan Kara <jack@suse.cz>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <20160204143344.GA6895@quack.suse.cz>
Sender: linux-fsdevel-owner@vger.kernel.org
List-Id: linux-ext4.vger.kernel.org

On Thu, Feb 04, 2016 at 03:33:44PM +0100, Jan Kara wrote:
> On Thu 04-02-16 17:02:02, Dmitry Monakhov wrote:
> > 
> > Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org>
> 
> Makes sense. You can add:
> 
> Reviewed-by: Jan Kara <jack@suse.cz>

Looks good to me as well.

Reviewed-by: Ross Zwisler <ross.zwisler@linux.intel.com>

> 								Honza
> > ---
> >  fs/dax.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/fs/dax.c b/fs/dax.c
> > index e0e9358..fc2e314 100644
> > --- a/fs/dax.c
> > +++ b/fs/dax.c
> > @@ -358,7 +358,8 @@ static int dax_radix_entry(struct address_space *mapping, pgoff_t index,
> >  	void *entry;
> >  
> >  	WARN_ON_ONCE(pmd_entry && !dirty);
> > -	__mark_inode_dirty(mapping->host, I_DIRTY_PAGES);
> > +	if (dirty)
> > +		__mark_inode_dirty(mapping->host, I_DIRTY_PAGES);
> >  
> >  	spin_lock_irq(&mapping->tree_lock);
> >  
> > -- 
> > 1.8.3.1
> > 
> -- 
> Jan Kara <jack@suse.com>
> SUSE Labs, CR