From: Christoph Hellwig Subject: Re: [PATCH v18 21/22] ext4: Add richacl support Date: Tue, 15 Mar 2016 00:18:54 -0700 Message-ID: <20160315071854.GG19747@infradead.org> References: <1456733847-17982-1-git-send-email-agruenba@redhat.com> <1456733847-17982-22-git-send-email-agruenba@redhat.com> <20160311142719.GG14808@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: "J. Bruce Fields" , Linux NFS Mailing List , Theodore Ts'o , linux-cifs@vger.kernel.org, Linux API , Trond Myklebust , LKML , XFS Developers , Christoph Hellwig , Andreas Dilger , Alexander Viro , linux-fsdevel , Jeff Layton , linux-ext4 , Anna Schumaker , "Aneesh Kumar K.V" To: Andreas Gruenbacher Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com List-Id: linux-ext4.vger.kernel.org On Mon, Mar 14, 2016 at 02:02:33PM +0100, Andreas Gruenbacher wrote: > On Fri, Mar 11, 2016 at 3:27 PM, Christoph Hellwig wrote: > >> +static inline int > >> +ext4_acl_chmod(struct inode *inode, umode_t mode) > >> +{ > >> + if (IS_RICHACL(inode)) > >> + return richacl_chmod(inode, inode->i_mode); > >> + return posix_acl_chmod(inode, inode->i_mode); > >> +} > > > > Thi isn't ext4-specific and potentially duplicated in every caller. > > Please provide this as a common helper. > > This can go in neither fs.h nor posix_acl.h nor richacl.h unless we > turn it into a macro, and I don't think we want to add a new header > file for such extreme trivia. I'd expect us to grow a few more of thos helper if we get the sharing right (either a real common base object, or wrappers for anything dealing with the acl pointers in the inode), so a new linux/acl.h should be fine. _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs