From: Linus Torvalds Subject: Re: [PATCH 01/21] fs: Replace CURRENT_TIME_SEC with current_fs_time() Date: Thu, 9 Jun 2016 12:15:03 -0700 Message-ID: References: <1465448705-25055-1-git-send-email-deepa.kernel@gmail.com> <1465448705-25055-2-git-send-email-deepa.kernel@gmail.com> <20160609073507.GA2790@quack2.suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: Deepa Dinamani , linux-fsdevel , Linux Kernel Mailing List , Arnd Bergmann , Thomas Gleixner , Al Viro , y2038@lists.linaro.org, Artem Bityutskiy , Adrian Hunter , linux-mtd , Evgeniy Dushistov , OGAWA Hirofumi , Jan Kara , "linux-ext4@vger.kernel.org" , David Howells , linux-afs@lists.infradead.org, "Tigran A. Aivazian" , "Theodore Ts'o" , Andreas Dilger , Jan Harkes , coda@cs.cmu.edu, codalist@coda.cs.cmu.edu, Bob Copeland , To: Jan Kara Return-path: Received: from mail-oi0-f66.google.com ([209.85.218.66]:35704 "EHLO mail-oi0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750810AbcFITPF (ORCPT ); Thu, 9 Jun 2016 15:15:05 -0400 In-Reply-To: <20160609073507.GA2790@quack2.suse.cz> Sender: linux-ext4-owner@vger.kernel.org List-ID: On Thu, Jun 9, 2016 at 12:35 AM, Jan Kara wrote: > > You create line longer than 80 characters for affs and reiserfs. Please > wrap those lines properly. No, please do *NOT* do things like that. These kind of mechanical patches should (a) be as mechanical as possible (and see elsewhere about why I think 'sb' should be 'inode' and the patch should have been 95% automated with a trivial script thanks to that change) (b) be made as easy to verify visually as possible. That (b) means that a conversion should *not* add whitespace fixups or add other non-mechanical cleanups, because it's a *lot* easier to see that a conversion like - inode->i_mtime = inode->i_ctime = CURRENT_TIME_SEC; + inode->i_mtime = inode->i_ctime = current_fs_time(inode); makes no other changes, but if you start doing line-splitting or other transformations (add new variables etc to get at 'sb'), suddenly you have to verify the patch at a completely different level. In other words, it's actually really important to make these kinds of bulk changes be very very obvious. Including to the point of making them visually easier to scan as a patch by not making any other changes. Linus