From: Theodore Ts'o Subject: Re: [PATCH] ext4: add project quota mount options Date: Fri, 8 Jul 2016 00:48:21 -0400 Message-ID: <20160708044821.GG19871@thunk.org> References: <1467875386-28092-1-git-send-email-wangshilong1991@gmail.com> <20160708031002.GF19871@thunk.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Eric Sandeen , Ext4 Developers List , Shuichi Ihara , Li Xi , Wang Shilong To: Wang Shilong Return-path: Received: from imap.thunk.org ([74.207.234.97]:41410 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751428AbcGHEs1 (ORCPT ); Fri, 8 Jul 2016 00:48:27 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-ext4-owner@vger.kernel.org List-ID: On Fri, Jul 08, 2016 at 12:36:56PM +0900, Wang Shilong wrote: > > I do agree with your point here, but the problem is as you can see come > from xfstests arguments from Dave Chinner. > > I don't think currently users will try to old interface with project quota. > But as your request, i think you need some tests for project quota... I think we need some real clarity about exactly what Dave is asking for. I think what Eric and Dave have been asking for is testing both of these two different quota management stacks: (1) XFS has ioctl's which come from the Irix days, and these are used by the xfs quota utilities. (2) Quotatools uses the quotactl(2) system call, and so there is an entirely **different** code path which we can exercise. This is a completely orthogonal question from which mount options and which mkfs options are used to set up project quota support for ext4. That's an ext4-specific concern, and I don't see why Dave would have any interest in what ext4 chooses to support here. - Ted