From: Jan Kara Subject: Re: [PATCH v4 05/12] dax: make 'wait_table' global variable static Date: Mon, 3 Oct 2016 11:36:03 +0200 Message-ID: <20161003093603.GK6457@quack2.suse.cz> References: <1475189370-31634-1-git-send-email-ross.zwisler@linux.intel.com> <1475189370-31634-6-git-send-email-ross.zwisler@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Theodore Ts'o , Matthew Wilcox , Dave Chinner , linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-xfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, Andreas Dilger , Alexander Viro , Jan Kara , linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Andrew Morton , linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Christoph Hellwig To: Ross Zwisler Return-path: Content-Disposition: inline In-Reply-To: <1475189370-31634-6-git-send-email-ross.zwisler-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-nvdimm-bounces-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org Sender: "Linux-nvdimm" List-Id: linux-ext4.vger.kernel.org On Thu 29-09-16 16:49:23, Ross Zwisler wrote: > The global 'wait_table' variable is only used within fs/dax.c, and > generates the following sparse warning: > > fs/dax.c:39:19: warning: symbol 'wait_table' was not declared. Should it be static? > > Make it static so it has scope local to fs/dax.c, and to make sparse happy. > > Signed-off-by: Ross Zwisler Looks fine. You can add: Reviewed-by: Jan Kara Honza > --- > fs/dax.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/dax.c b/fs/dax.c > index 9b9be8a..ac28cdf 100644 > --- a/fs/dax.c > +++ b/fs/dax.c > @@ -52,7 +52,7 @@ > #define DAX_WAIT_TABLE_BITS 12 > #define DAX_WAIT_TABLE_ENTRIES (1 << DAX_WAIT_TABLE_BITS) > > -wait_queue_head_t wait_table[DAX_WAIT_TABLE_ENTRIES]; > +static wait_queue_head_t wait_table[DAX_WAIT_TABLE_ENTRIES]; > > static int __init init_dax_wait_table(void) > { > -- > 2.7.4 > > -- Jan Kara SUSE Labs, CR