From: Theodore Ts'o <tytso@mit.edu>
Subject: Re: [PATCH] fscrypto: move ioctl processing more fully
 into common code
Date: Sat, 26 Nov 2016 19:09:01 -0500
Message-ID: <20161127000901.wuyl6t6wp6qhmkrs@thunk.org>
References: <1476723246-47420-1-git-send-email-ebiggers@google.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Cc: linux-fsdevel@vger.kernel.org, jaegeuk@kernel.org,
	linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
To: Eric Biggers <ebiggers@google.com>
Content-Disposition: inline
In-Reply-To: <1476723246-47420-1-git-send-email-ebiggers@google.com>
Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net

On Mon, Oct 17, 2016 at 09:54:06AM -0700, Eric Biggers wrote:
> In addition, make the common functions do the copies to and from
> userspace rather than duplicating this code within each filesystem, and
> memset the policy to 0 to make it clear there is no stack leak.

I don't see any point of doing this, given that we initialize all
parts of the fscrypt_policy structure; and since this structure is
part of UAPI, we can't change it without breaking userspace.

I'll apply this with the memset (and the above comment in the commit
description) removed.

					- Ted

------------------------------------------------------------------------------