From: Ross Zwisler Subject: Re: [PATCH 4/6] dax: Finish fault completely when loading holes Date: Thu, 1 Dec 2016 15:13:11 -0700 Message-ID: <20161201221311.GA13739@linux.intel.com> References: <1479980796-26161-1-git-send-email-jack@suse.cz> <1479980796-26161-5-git-send-email-jack@suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, Johannes Weiner , linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jan Kara Return-path: Content-Disposition: inline In-Reply-To: <1479980796-26161-5-git-send-email-jack-AlSwsSmVLrQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-nvdimm-bounces-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org Sender: "Linux-nvdimm" List-Id: linux-ext4.vger.kernel.org On Thu, Nov 24, 2016 at 10:46:34AM +0100, Jan Kara wrote: > The only case when we do not finish the page fault completely is when we > are loading hole pages into a radix tree. Avoid this special case and > finish the fault in that case as well inside the DAX fault handler. It > will allow us for easier iomap handling. > > Signed-off-by: Jan Kara This seems correct to me. Reviewed-by: Ross Zwisler