From: Chao Yu Subject: Re: [f2fs-dev] [PATCH 2/4] f2fs: don't bother checking for encryption key in ->mmap() Date: Tue, 23 May 2017 21:38:40 +0800 Message-ID: References: <20170523003945.14279-1-ebiggers3@gmail.com> <20170523003945.14279-3-ebiggers3@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: Theodore Ts'o , Eric Biggers , linux-f2fs-devel@lists.sourceforge.net, linux-mtd@lists.infradead.org, Jaegeuk Kim , linux-ext4@vger.kernel.org To: Eric Biggers , linux-fscrypt@vger.kernel.org Return-path: Received: from mail.kernel.org ([198.145.29.99]:49198 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759036AbdEWNjm (ORCPT ); Tue, 23 May 2017 09:39:42 -0400 In-Reply-To: <20170523003945.14279-3-ebiggers3@gmail.com> Content-Language: en-US Sender: linux-ext4-owner@vger.kernel.org List-ID: On 2017/5/23 8:39, Eric Biggers wrote: > From: Eric Biggers > > Since only an open file can be mmap'ed, and we only allow open()ing an > encrypted file when its key is available, there is no need to check for > the key again before permitting each mmap(). > > This f2fs copy of this code was also broken in that it wouldn't actually > have failed if the key was in fact unavailable. > > Signed-off-by: Eric Biggers Acked-by: Chao Yu Thanks, > --- > fs/f2fs/file.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c > index 61af721329fa..ff4db3efc0ac 100644 > --- a/fs/f2fs/file.c > +++ b/fs/f2fs/file.c > @@ -415,14 +415,6 @@ static int f2fs_file_mmap(struct file *file, struct vm_area_struct *vma) > struct inode *inode = file_inode(file); > int err; > > - if (f2fs_encrypted_inode(inode)) { > - err = fscrypt_get_encryption_info(inode); > - if (err) > - return 0; > - if (!f2fs_encrypted_inode(inode)) > - return -ENOKEY; > - } > - > /* we don't need to use inline_data strictly */ > err = f2fs_convert_inline_inode(inode); > if (err) >