From: Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH 07/10] fs: return on congested block device
Date: Mon, 5 Jun 2017 09:35:24 -0600
Message-ID: <dedfe92d-6452-4f29-044d-34837c4da825@kernel.dk>
References: <20170605053540.19393-1-rgoldwyn@suse.de>
 <20170605053540.19393-8-rgoldwyn@suse.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: jack@suse.com, hch@infradead.org, linux-block@vger.kernel.org,
        linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org,
        linux-xfs@vger.kernel.org, linux-api@vger.kernel.org,
        adam.manzanares@wdc.com, viro@zeniv.linux.org.uk,
        Goldwyn Rodrigues <rgoldwyn@suse.com>
To: Goldwyn Rodrigues <rgoldwyn@suse.de>, linux-fsdevel@vger.kernel.org
Return-path: <linux-block-owner@vger.kernel.org>
In-Reply-To: <20170605053540.19393-8-rgoldwyn@suse.de>
Content-Language: en-US
Sender: linux-block-owner@vger.kernel.org
List-Id: linux-ext4.vger.kernel.org

On 06/04/2017 11:35 PM, Goldwyn Rodrigues wrote:
> @@ -1900,6 +1905,17 @@ generic_make_request_checks(struct bio *bio)
>  		goto end_io;
>  	}
>  
> +	/*
> +	 * For a REQ_NOWAIT based request, return -EOPNOTSUPP
> +	 * if queue does not have QUEUE_FLAG_NOWAIT_SUPPORT set
> +	 * and if it is not a request based queue.
> +	 */
> +
> +	if ((bio->bi_opf & REQ_NOWAIT) && !queue_is_rq_based(q)) {
> +		err = -EOPNOTSUPP;
> +		goto end_io;
> +	}

There is no QUEUE_FLAG_NOWAIT, this looks like a somewhat stale comment.

This patch should be prefixed with 'block', not 'fs'.

-- 
Jens Axboe