From: Eryu Guan Subject: Re: [xfstests PATCH v4 5/5] btrfs: make a btrfs version of writeback error reporting test Date: Thu, 15 Jun 2017 13:38:36 +0800 Message-ID: <20170615053836.GD17436@eguan.usersys.redhat.com> References: <20170612124213.14855-1-jlayton@redhat.com> <20170612124213.14855-6-jlayton@redhat.com> <20170613084034.GE4788@eguan.usersys.redhat.com> <1497441317.6752.2.camel@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Andrew Morton , Al Viro , Jan Kara , tytso@mit.edu, axboe@kernel.dk, mawilcox@microsoft.com, ross.zwisler@linux.intel.com, corbet@lwn.net, Chris Mason , Josef Bacik , David Sterba , "Darrick J . Wong" , David Howells , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-block@vger.kernel.org To: Jeff Layton Return-path: Content-Disposition: inline In-Reply-To: <1497441317.6752.2.camel@redhat.com> Sender: owner-linux-mm@kvack.org List-Id: linux-ext4.vger.kernel.org On Wed, Jun 14, 2017 at 07:55:17AM -0400, Jeff Layton wrote: > On Tue, 2017-06-13 at 16:40 +0800, Eryu Guan wrote: > > On Mon, Jun 12, 2017 at 08:42:13AM -0400, Jeff Layton wrote: > > > Make a new btrfs/999 test that works the way Chris Mason suggested: > > > > > > Build a filesystem with 2 devices that stripes the data across > > > both devices, but mirrors metadata across both. Then, make one > > > of the devices fail and see how fsync is handled. > > > > > > Signed-off-by: Jeff Layton > > > --- > > > tests/btrfs/999 | 93 +++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > > > Missing btrfs/999.out file > > > > > tests/btrfs/group | 1 + > > > 2 files changed, 94 insertions(+) > > > create mode 100755 tests/btrfs/999 > > > > > > diff --git a/tests/btrfs/999 b/tests/btrfs/999 > > > new file mode 100755 > > > index 000000000000..84031cc0d913 > > > --- /dev/null > > > +++ b/tests/btrfs/999 > > > @@ -0,0 +1,93 @@ > > > +#! /bin/bash > > > +# FS QA Test No. 999 > > > +# > > > +# Open a file several times, write to it, fsync on all fds and make sure that > > > +# they all return 0. Change the device to start throwing errors. Write again > > > +# on all fds and fsync on all fds. Ensure that we get errors on all of them. > > > +# Then fsync on all one last time and verify that all return 0. > > > +# > > > +#----------------------------------------------------------------------- > > > +# Copyright (c) 2017, Jeff Layton > > > +# > > > +# This program is free software; you can redistribute it and/or > > > +# modify it under the terms of the GNU General Public License as > > > +# published by the Free Software Foundation. > > > +# > > > +# This program is distributed in the hope that it would be useful, > > > +# but WITHOUT ANY WARRANTY; without even the implied warranty of > > > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > > > +# GNU General Public License for more details. > > > +# > > > +# You should have received a copy of the GNU General Public License > > > +# along with this program; if not, write the Free Software Foundation, > > > +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA > > > +#----------------------------------------------------------------------- > > > + > > > +seq=`basename $0` > > > +seqres=$RESULT_DIR/$seq > > > +echo "QA output created by $seq" > > > + > > > +here=`pwd` > > > +tmp=/tmp/$$ > > > +status=1 # failure is the default! > > > +trap "_cleanup; exit \$status" 0 1 2 3 15 > > > + > > > +_cleanup() > > > +{ > > > + cd / > > > + rm -rf $tmp.* $testdir > > > + _dmerror_cleanup > > > +} > > > + > > > +# get standard environment, filters and checks > > > +. ./common/rc > > > +. ./common/filter > > > +. ./common/dmerror > > > + > > > +# real QA test starts here > > > +_supported_os Linux > > > +_require_dm_target error > > > +_require_test_program fsync-err > > > +_require_test_program dmerror > > > + > > > +# bring up dmerror device > > > +_scratch_unmount > > > +_dmerror_init > > > + > > > +# Replace first device with error-test device > > > +old_SCRATCH_DEV=$SCRATCH_DEV > > > +SCRATCH_DEV_POOL=`echo $SCRATCH_DEV_POOL | perl -pe "s#$SCRATCH_DEV#$DMERROR_DEV#"` > > > +SCRATCH_DEV=$DMERROR_DEV > > > + > > > +_require_scratch > > > +_require_scratch_dev_pool > > > > Need "_require_scratch_dev_pool_equal_size" too, since test creates > > raid1 profile for metadata. Sorry, it's not needed here. I got confused with device replace operation, only "replace" needs this require rule. Thanks for confirming! Eryu -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org