From: Jeff Layton Subject: Re: [PATCH v7 11/22] fs: new infrastructure for writeback error handling and reporting Date: Tue, 20 Jun 2017 08:56:16 -0400 Message-ID: <1497963376.4555.4.camel@redhat.com> References: <20170616193427.13955-1-jlayton@redhat.com> <20170616193427.13955-12-jlayton@redhat.com> <20170620123433.GB19781@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: Andrew Morton , Al Viro , Jan Kara , tytso@mit.edu, axboe@kernel.dk, mawilcox@microsoft.com, ross.zwisler@linux.intel.com, corbet@lwn.net, Chris Mason , Josef Bacik , David Sterba , "Darrick J . Wong" , Carlos Maiolino , Eryu Guan , David Howells , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-block@vger.kernel.org To: Christoph Hellwig Return-path: Received: from mail-qt0-f179.google.com ([209.85.216.179]:32776 "EHLO mail-qt0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751130AbdFTM4U (ORCPT ); Tue, 20 Jun 2017 08:56:20 -0400 Received: by mail-qt0-f179.google.com with SMTP id u12so132671802qth.0 for ; Tue, 20 Jun 2017 05:56:19 -0700 (PDT) In-Reply-To: <20170620123433.GB19781@infradead.org> Sender: linux-ext4-owner@vger.kernel.org List-ID: On Tue, 2017-06-20 at 05:34 -0700, Christoph Hellwig wrote: > > @@ -393,6 +394,7 @@ struct address_space { > > gfp_t gfp_mask; /* implicit gfp mask for allocations */ > > struct list_head private_list; /* ditto */ > > void *private_data; /* ditto */ > > + errseq_t wb_err; > > } __attribute__((aligned(sizeof(long)))); > > /* > > * On most architectures that alignment is already the case; but > > @@ -847,6 +849,7 @@ struct file { > > * Must not be taken from IRQ context. > > */ > > spinlock_t f_lock; > > + errseq_t f_wb_err; > > atomic_long_t f_count; > > unsigned int f_flags; > > fmode_t f_mode; > > Did you check the sizes of the structure before and after? > These places don't look like holes in the packing, but there probably > are some available. > Yes. That one actually plugs a 4 byte hole in struct file on x86_64. > > +static inline int filemap_check_wb_err(struct address_space *mapping, errseq_t since) > > Overly long line here (the patch has a few more) > Ok, I'll fix those up. -- Jeff Layton