From: Theodore Ts'o Subject: Re: [PATCH 3/4] ubifs: don't bother checking for encryption key in ->mmap() Date: Fri, 23 Jun 2017 12:09:07 -0400 Message-ID: <20170623160907.ppwcqehvrehjtury@thunk.org> References: <20170523003945.14279-1-ebiggers3@gmail.com> <20170523003945.14279-4-ebiggers3@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Eric Biggers , linux-fscrypt@vger.kernel.org, Eric Biggers , linux-f2fs-devel@lists.sourceforge.net, "linux-mtd@lists.infradead.org" , Jaegeuk Kim , linux-ext4@vger.kernel.org To: Richard Weinberger Return-path: Received: from imap.thunk.org ([74.207.234.97]:37084 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752727AbdFWQJS (ORCPT ); Fri, 23 Jun 2017 12:09:18 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-ext4-owner@vger.kernel.org List-ID: On Tue, May 23, 2017 at 04:14:20PM +0200, Richard Weinberger wrote: > On Tue, May 23, 2017 at 2:39 AM, Eric Biggers wrote: > > From: Eric Biggers > > > > Since only an open file can be mmap'ed, and we only allow open()ing an > > encrypted file when its key is available, there is no need to check for > > the key again before permitting each mmap(). > > > > Signed-off-by: Eric Biggers > > Acked-by: Richard Weinberger There are some patches that were sent to linux-fscrypt (including this one) that are specific to ubifs that don't appear to be in linux-next as of this writing. I can include them in the fscrypt tree (which I am updating somewhat belatedly; sorry, crazy travel schedule has made me be late attending to fscrypt), but it probably makes more sense for the change to go in via the ubifs tree. The f2fs version of the "don't bother checking for encryption key" is already in linux-next, via the f2fs tree, for example. So I'm planning on NOT taking the ubifs-specific patches that are in the linux-fscrypto patch queue; unless Richard, you want to specifically ask me to do so. Cheers, - Ted