From: William Koh Subject: Re: [PATCH] fs: ext4: inode->i_generation not assigned 0. Date: Thu, 29 Jun 2017 04:37:14 +0000 Message-ID: <7CD38230-D961-428F-B2E9-2C0E28CAF442@fb.com> References: <20A40B3C-E179-432B-B56F-BDAAF0CD2E1F@dilger.ca> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: Theodore Ts'o , linux-ext4 , lkml , Kernel Team , "J. Bruce Fields" , linux-fsdevel , Trond Myklebust To: Andreas Dilger Return-path: In-Reply-To: <20A40B3C-E179-432B-B56F-BDAAF0CD2E1F@dilger.ca> Content-Language: en-US Content-ID: <8A81596E499CC54E8AAC53CE7D405AA9@namprd15.prod.outlook.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-ext4.vger.kernel.org T24gNi8yOC8xNywgNzozMiBQTSwgIkFuZHJlYXMgRGlsZ2VyIiA8YWRpbGdlckBkaWxnZXIuY2E+ IHdyb3RlOg0KDQogICAgT24gSnVuIDI4LCAyMDE3LCBhdCA0OjA2IFBNLCBLeXVuZ2NoYW4gS29o IDxra2M2MTk2QGZiLmNvbT4gd3JvdGU6DQogICAgPiANCiAgICA+IEluIGZzL2V4dDQvc3VwZXIu YywgdGhlIGZ1bmN0aW9uIGV4dDRfbmZzX2dldF9pbm9kZSB0YWtlcyBhcyBpbnB1dA0KICAgID4g ImdlbmVyYXRpb24iIHRoYXQgY2FuIGJlIHVzZWQgdG8gc3BlY2lmeSB0aGUgZ2VuZXJhdGlvbiBv ZiB0aGUgaW5vZGUgdG8NCiAgICA+IGJlIHJldHVybmVkLiBXaGVuIDAgaXMgZ2l2ZW4gYXMgaW5w dXQsIHRoZW4gaW5vZGVzIG9mIGFueSBnZW5lcmF0aW9uIGNhbg0KICAgID4gYmUgcmV0dXJuZWQu IFRoZXJlZm9yZSwgZ2VuZXJhdGlvbiAwIGlzIGEgc3BlY2lhbCBjYXNlIHRoYXQgc2hvdWxkIGJl DQogICAgPiBhdm9pZGVkIHdoZW4gYXNzaWduaW5nIGdlbmVyYXRpb24gdG8gaW5vZGVzLg0KICAg IA0KICAgIEknZCBhZ3JlZSB3aXRoIHRoaXMgY2hhbmdlIHRvIGF2b2lkIGFzc2lnbmluZyBnZW5l cmF0aW9uID09IDAgdG8gcmVhbCBpbm9kZXMuDQogICAgDQogICAgQWxzbywgdGhlIHNlcGFyYXRl IHF1ZXN0aW9uIGFyaXNlcyBhYm91dCB3aGV0aGVyIHdlIG5lZWQgdG8gYWxsb3cgZmlsZSBoYW5k bGUNCiAgICBsb29rdXAgd2l0aCBnZW5lcmF0aW9uID09IDA/ICBUaGF0IGFsbG93cyBGSUQgZ3Vl c3NpbmcgZWFzaWx5LCB3aGlsZSByZXF1aXJpbmcNCiAgICBhIG5vbi16ZXJvIGdlbmVyYXRpb24g bWFrZXMgdGhhdCBhIGxvdCBoYXJkZXIuDQogICAgDQogICAgV2hhdCBhcmUgdGhlIGNhc2VzIHdo ZXJlIGdlbmVyYXRpb24gPT0gMCBhcmUgdXNlZD8NCg0KSG9uZXN0bHksIEnigJltIG5vdCB0b28g c3VyZS4gSSBqdXN0IG5vdGljZWQgdGhhdCBnZW5lcmF0aW9uIDAgd2FzIGEgc3BlY2lhbA0KY2Fz ZSBmcm9tIHJlYWRpbmcgdGhlIGNvZGUuDQoNCiAgICA+IEEgbmV3IGlubGluZSBmdW5jdGlvbiwg ZXh0NF9pbm9kZV9zZXRfZ2VuLCB3aWxsIHRha2UgY2FyZSBvZiB0aGUNCiAgICA+IHByb2JsZW0u ICBOb3csIGlub2RlcyBjYW5ub3QgaGF2ZSBhIGdlbmVyYXRpb24gb2YgMCwgc28gdGhpcyBwYXRj aCBmaXhlcw0KICAgID4gdGhlIGlzc3VlLg0KICAgID4gDQogICAgPiBTaWduZWQtb2ZmLWJ5OiBL eXVuZ2NoYW4gS29oIDxra2M2MTk2QGZiLmNvbT4NCiAgICA+IA0KICAgID4gZGlmZiAtLWdpdCBh L2ZzL2V4dDQvZXh0NC5oIGIvZnMvZXh0NC9leHQ0LmgNCiAgICA+IGluZGV4IDMyMTkxNTQuLjc0 YzY2NzcgMTAwNjQ0DQogICAgPiAtLS0gYS9mcy9leHQ0L2V4dDQuaA0KICAgID4gKysrIGIvZnMv ZXh0NC9leHQ0LmgNCiAgICA+IEBAIC0xNTQ5LDYgKzE1NDksMTQgQEAgc3RhdGljIGlubGluZSBp bnQgZXh0NF92YWxpZF9pbnVtKHN0cnVjdCBzdXBlcl9ibG9jayAqc2IsIHVuc2lnbmVkIGxvbmcg aW5vKQ0KICAgID4gCQkgaW5vIDw9IGxlMzJfdG9fY3B1KEVYVDRfU0Ioc2IpLT5zX2VzLT5zX2lu b2Rlc19jb3VudCkpOw0KICAgID4gfQ0KICAgID4gDQogICAgPiArc3RhdGljIGlubGluZSB2b2lk IGV4dDRfaW5vZGVfc2V0X2dlbihzdHJ1Y3QgaW5vZGUgKmlub2RlLA0KICAgID4gKwkJCQkgICAg ICBzdHJ1Y3QgZXh0NF9zYl9pbmZvICpzYmkpDQogICAgPiArew0KICAgID4gKwlpbm9kZS0+aV9n ZW5lcmF0aW9uID0gc2JpLT5zX25leHRfZ2VuZXJhdGlvbisrOw0KICAgID4gKwlpZiAoIWlub2Rl LT5pX2dlbmVyYXRpb24pDQogICAgDQogICAgVGhpcyBzaG91bGQgYmUgbWFya2VkICJ1bmxpa2Vs eSgpIiBzaW5jZSBpdCBoYXBwZW5zIGF0IG1vc3Qgb25jZSBldmVyeSA0Qg0KICAgIGZpbGUgY3Jl YXRpb25zICh0aG91Z2ggbGlrZWx5IGV2ZW4gbGVzcyBzaW5jZSBpdCBpcyB1bmxpa2VseSB0aGF0 IHNvIG1hbnkNCiAgICBmaWxlcyB3aWxsIGJlIGNyZWF0ZWQgaW4gYSBzaW5nbGUgbW91bnQpLg0K DQpHb3QgaXQuDQogICAgDQogICAgPiArCQlpbm9kZS0+aV9nZW5lcmF0aW9uID0gc2JpLT5zX25l eHRfZ2VuZXJhdGlvbisrOw0KICAgID4gK30NCiAgICA+ICsNCiAgICA+IA0KICAgID4gZGlmZiAt LWdpdCBhL2ZzL2V4dDQvaWFsbG9jLmMgYi9mcy9leHQ0L2lhbGxvYy5jDQogICAgPiBpbmRleCA5 OGFjMmYxLi5kMzNmNmYwIDEwMDY0NA0KICAgID4gLS0tIGEvZnMvZXh0NC9pYWxsb2MuYw0KICAg ID4gKysrIGIvZnMvZXh0NC9pYWxsb2MuYw0KICAgID4gQEAgLTEwNzIsNyArMTA3Miw3IEBAIHN0 cnVjdCBpbm9kZSAqX19leHQ0X25ld19pbm9kZShoYW5kbGVfdCAqaGFuZGxlLCBzdHJ1Y3QgaW5v ZGUJfQ0KICAgID4gCXNwaW5fbG9jaygmc2JpLT5zX25leHRfZ2VuX2xvY2spOw0KICAgID4gLQlp bm9kZS0+aV9nZW5lcmF0aW9uID0gc2JpLT5zX25leHRfZ2VuZXJhdGlvbisrOw0KICAgID4gKwll eHQ0X2lub2RlX3NldF9nZW4oaW5vZGUsIHNiaSk7DQogICAgPiAJc3Bpbl91bmxvY2soJnNiaS0+ c19uZXh0X2dlbl9sb2NrKTsNCiAgICA+IA0KICAgID4gZGlmZiAtLWdpdCBhL2ZzL2V4dDQvaW9j dGwuYyBiL2ZzL2V4dDQvaW9jdGwuYw0KICAgID4gaW5kZXggMGMyMWUyMi4uZDUyYTQ2NyAxMDA2 NDQNCiAgICA+IC0tLSBhL2ZzL2V4dDQvaW9jdGwuYw0KICAgID4gKysrIGIvZnMvZXh0NC9pb2N0 bC5jDQogICAgPiBAQCAtMTYwLDggKzE2MCw4IEBAIHN0YXRpYyBsb25nIHN3YXBfaW5vZGVfYm9v dF9sb2FkZXIoc3RydWN0IHN1cGVyX2Jsb2NrICpzYiwNCiAgICA+IA0KICAgID4gCXNwaW5fbG9j aygmc2JpLT5zX25leHRfZ2VuX2xvY2spOw0KICAgID4gLQlpbm9kZS0+aV9nZW5lcmF0aW9uID0g c2JpLT5zX25leHRfZ2VuZXJhdGlvbisrOw0KICAgID4gLQlpbm9kZV9ibC0+aV9nZW5lcmF0aW9u ID0gc2JpLT5zX25leHRfZ2VuZXJhdGlvbisrOw0KICAgID4gKwlleHQ0X2lub2RlX3NldF9nZW4o aW5vZGUsIHNiaSk7DQogICAgPiArCWV4dDRfaW5vZGVfc2V0X2dlbihpbm9kZV9ibCwgc2JpKTsN CiAgICA+IAlzcGluX3VubG9jaygmc2JpLT5zX25leHRfZ2VuX2xvY2spOw0KICAgID4gDQogICAg DQogICAgDQogICAgQ2hlZXJzLCBBbmRyZWFzDQoNClRoaXMgaXMgYXBwbGljYWJsZSB0byBtYW55 IGZzLCBpbmNsdWRpbmcgZXh0MiwgZXh0NCwgZXhvZnMsIGpmcywgYW5kIGYyZnMuDQpUaGVyZWZv cmUsIGEgc2hhcmVkIGhlbHBlciBpbiBsaW51eC9mcy5oIHdpbGwgYWxsb3cgZm9yIGVhc3kgY2hh bmdlcw0KaW4gYWxsIGZzLiBJcyB0aGVyZSBhbnkgcmVhc29uIHRoYXQgbWlnaHQgYmUgYSBiYWQg aWRlYT8NCg0KQmVzdCwNCkt5dW5nY2hhbiBLb2ggDQogICAgDQogICAgDQogICAgDQogICAgDQoN Cg==