From: Ross Zwisler Subject: Re: [PATCH 06/13] dax: Inline dax_insert_mapping() into the callsite Date: Fri, 18 Aug 2017 16:10:32 -0600 Message-ID: <20170818221032.GE32627@linux.intel.com> References: <20170817160815.30466-1-jack@suse.cz> <20170817160815.30466-7-jack@suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Christoph Hellwig , Boaz Harrosh , linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org, linux-xfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Andy Lutomirski , linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jan Kara Return-path: Content-Disposition: inline In-Reply-To: <20170817160815.30466-7-jack-AlSwsSmVLrQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-nvdimm-bounces-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org Sender: "Linux-nvdimm" List-Id: linux-ext4.vger.kernel.org On Thu, Aug 17, 2017 at 06:08:08PM +0200, Jan Kara wrote: > dax_insert_mapping() has only one callsite and we will need to further > fine tune what it does for synchronous faults. Just inline it into the > callsite so that we don't have to pass awkward bools around. > > Signed-off-by: Jan Kara Looks good. Reviewed-by: Ross Zwisler