From: Christoph Hellwig Subject: Re: [PATCH 09/13] dax: Allow dax_iomap_fault() to return pfn Date: Wed, 23 Aug 2017 11:34:00 -0700 Message-ID: <20170823183400.GG13778@infradead.org> References: <20170817160815.30466-1-jack@suse.cz> <20170817160815.30466-10-jack@suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: linux-xfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org, Christoph Hellwig , Andy Lutomirski , linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Boaz Harrosh To: Jan Kara Return-path: Content-Disposition: inline In-Reply-To: <20170817160815.30466-10-jack-AlSwsSmVLrQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-nvdimm-bounces-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org Sender: "Linux-nvdimm" List-Id: linux-ext4.vger.kernel.org > @@ -1416,6 +1416,7 @@ static int dax_iomap_pmd_fault(struct vm_fault *vmf, > * @vmf: The description of the fault > * @pe_size: Size of the page to fault in > * @ops: Iomap ops passed from the file system > + * @pfnp: PFN to insert for synchronous faults if fsync is required > * > * When a page fault occurs, filesystems may call this helper in > * their fault handler for DAX files. dax_iomap_fault() assumes the caller > @@ -1423,13 +1424,13 @@ static int dax_iomap_pmd_fault(struct vm_fault *vmf, > * successfully. > */ > int dax_iomap_fault(struct vm_fault *vmf, enum page_entry_size pe_size, > - const struct iomap_ops *ops) > + const struct iomap_ops *ops, pfn_t *pfnp) Please keep the iomap_ops argument the last one for the exported function (and probably all others for consistency). Otherwise looks good: Reviewed-by: Christoph Hellwig