From: Jan Kara Subject: Re: [PATCH v3 1/4] dax: introduce a fs_dax_get_by_bdev() helper Date: Thu, 31 Aug 2017 10:25:15 +0200 Message-ID: <20170831082515.GF7897@quack2.suse.cz> References: <150412222686.10177.8031279869867070772.stgit@dwillia2-desk3.amr.corp.intel.com> <150412223265.10177.11004612169458058274.stgit@dwillia2-desk3.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: linux-xfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Jan Kara , Christoph Hellwig , linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org To: Dan Williams Return-path: Content-Disposition: inline In-Reply-To: <150412223265.10177.11004612169458058274.stgit-p8uTFz9XbKj2zm6wflaqv1nYeNYlB/vhral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-nvdimm-bounces-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org Sender: "Linux-nvdimm" List-Id: linux-ext4.vger.kernel.org On Wed 30-08-17 12:43:52, Dan Williams wrote: > Add a helper that can replace the following common pattern: > > if (blk_queue_dax(bdev->bd_queue)) > fs_dax_get_by_host(bdev->bd_disk->disk_name); > > This will be used to move dax_device lookup from iomap-operation time to > fs-mount time. > > Cc: Jan Kara > Cc: Christoph Hellwig > Signed-off-by: Dan Williams Looks good to me. You can add: Reviewed-by: Jan Kara Honza -- Jan Kara SUSE Labs, CR