From: Theodore Ts'o Subject: Re: [PATCH v2 4/5] ext4: add ext4_should_use_dax() Date: Thu, 12 Oct 2017 12:01:28 -0400 Message-ID: <20171012160128.qzmsttp7mw3c4q22@thunk.org> References: <20170912050526.7627-1-ross.zwisler@linux.intel.com> <20170912050526.7627-5-ross.zwisler@linux.intel.com> <20170912064612.GD16554@quack2.suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org, Dave Chinner , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Christoph Hellwig , Andreas Dilger , linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jan Kara Return-path: Content-Disposition: inline In-Reply-To: <20170912064612.GD16554-4I4JzKEfoa/jFM9bn6wA6Q@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-nvdimm-bounces-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org Sender: "Linux-nvdimm" List-Id: linux-ext4.vger.kernel.org On Tue, Sep 12, 2017 at 08:46:12AM +0200, Jan Kara wrote: > On Mon 11-09-17 23:05:25, Ross Zwisler wrote: > > This helper, in the spirit of ext4_should_dioread_nolock() et al., replaces > > the complex conditional in ext4_set_inode_flags(). > > > > Signed-off-by: Ross Zwisler > > Yeah, makes sense to me. You can add: > > Reviewed-by: Jan Kara Thanks, applied. - Ted