From: Ross Zwisler Subject: Re: [PATCH 2/2] ext4: Fix ENOSPC handling in DAX page fault handler Date: Thu, 21 Dec 2017 10:17:01 -0700 Message-ID: <20171221171701.GC2158@linux.intel.com> References: <20171221163055.3943-1-jack@suse.cz> <20171221163055.3943-3-jack@suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Ted Tso , linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jan Kara Return-path: Content-Disposition: inline In-Reply-To: <20171221163055.3943-3-jack-AlSwsSmVLrQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-nvdimm-bounces-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org Sender: "Linux-nvdimm" List-Id: linux-ext4.vger.kernel.org On Thu, Dec 21, 2017 at 05:30:55PM +0100, Jan Kara wrote: > When allocation of underlying block for a page fault fails, we fail the > fault with SIGBUS. However we may well hit ENOSPC just due to lots of > free blocks being held by the running / committing transaction. So > propagate the error from ext4_iomap_begin() and implement do standard > allocation retry loop in ext4_dax_huge_fault(). > > Signed-off-by: Jan Kara Looks good. Reviewed-by: Ross Zwisler