From: Ross Zwisler Subject: [fstests PATCH v2] generic/347: dm-thin lacks DAX support Date: Thu, 18 Jan 2018 09:07:37 -0700 Message-ID: <20180118160737.24708-1-ross.zwisler@linux.intel.com> References: <20180118042343.GQ3102@eguan.usersys.redhat.com> Cc: Ross Zwisler , linux-ext4@vger.kernel.org, linux-nvdimm@lists.01.org, dave.jiang@intel.com To: Eryu Guan , fstests@vger.kernel.org Return-path: In-Reply-To: <20180118042343.GQ3102@eguan.usersys.redhat.com> Sender: fstests-owner@vger.kernel.org List-Id: linux-ext4.vger.kernel.org generic/347 currently fails when run in conjunction with the DAX mount option: generic/347 72s ... - output mismatch (see /root/project/xfstests/results//generic/347.out.bad) --- tests/generic/347.out 2016-05-12 11:56:32.086618744 -0600 +++ /root/project/xfstests/results//generic/347.out.bad 2018-01-17 16:04:33.459348448 -0700 @@ -1,2 +1,3 @@ QA output created by 347 +mount: /mnt/xfstests_scratch: can't read superblock on /dev/mapper/thin-vol. === completed ... (Run 'diff -u tests/generic/347.out /root/project/xfstests/results//generic/347.out.bad' to see the entire diff) This is expected because the dm-thin target currently lacks DAX support. Just skip this test if we are using DAX. Signed-off-by: Ross Zwisler --- common/dmthin | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/common/dmthin b/common/dmthin index baab6284..da0ad284 100644 --- a/common/dmthin +++ b/common/dmthin @@ -35,6 +35,11 @@ DMTHIN_POOL_DEV="/dev/mapper/$DMTHIN_POOL_NAME" DMTHIN_VOL_NAME="thin-vol" DMTHIN_VOL_DEV="/dev/mapper/$DMTHIN_VOL_NAME" +echo $MOUNT_OPTIONS | grep -q dax +if [ $? -eq 0 ]; then + _notrun "Cannot run tests with DAX on dmthin devices" +fi + _dmthin_cleanup() { $UMOUNT_PROG $SCRATCH_MNT > /dev/null 2>&1 -- 2.14.3