From: "Darrick J. Wong" Subject: Re: [PATCH v4 1/3] fs: allow per-device dax status checking for filesystems Date: Thu, 15 Feb 2018 11:06:58 -0800 Message-ID: <20180215190658.GQ5217@magnolia> References: <151871644696.27617.4390718895806529377.stgit@djiang5-desk3.ch.intel.com> <151871655228.27617.3514495396592472682.stgit@djiang5-desk3.ch.intel.com> <20180215175241.GA25223@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: linux-xfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org, david-FqsqvQoI3Ljby3iVrkZq2A@public.gmane.org, Christoph Hellwig , linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Dave Jiang Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-nvdimm-bounces-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org Sender: "Linux-nvdimm" List-Id: linux-ext4.vger.kernel.org On Thu, Feb 15, 2018 at 10:58:54AM -0700, Dave Jiang wrote: > On 02/15/2018 10:52 AM, Christoph Hellwig wrote: > >> /** > >> - * __bdev_dax_supported() - Check if the device supports dax for filesystem > >> + * bdev_dax_supported() - Check if the device supports dax for filesystem > >> * @sb: The superblock of the device > >> + * @bdev: block device to check > >> * @blocksize: The block size of the device > >> * > >> * This is a library function for filesystems to check if the block device > >> @@ -82,9 +83,9 @@ EXPORT_SYMBOL_GPL(fs_dax_get_by_bdev); > >> * > >> * Return: negative errno if unsupported, 0 if supported. > >> */ > >> -int __bdev_dax_supported(struct super_block *sb, int blocksize) > >> +int bdev_dax_supported(struct super_block *sb, struct block_device *bdev, > >> + int blocksize) > >> { > >> - struct block_device *bdev = sb->s_bdev; > >> struct dax_device *dax_dev; > >> pgoff_t pgoff; > >> int err, id; > > > > This now only uses sb for sb->s_id. It might be better to use bdevname > > to print the device name and don't bother passing a sb at all. > > > > I think Darrick wanted to keep the API the same for non-XFS users. I'm > ok with dropping the passed in sb if Darrick has no objections. Fine with me to use bdevname. --D > -- > To unsubscribe from this list: send the line "unsubscribe linux-xfs" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html