From: Christoph Hellwig Subject: Re: [PATCH v7 05/14] ext4, dax: introduce ext4_dax_aops Date: Thu, 29 Mar 2018 20:09:27 +0200 Message-ID: <20180329180927.GA16055@lst.de> References: <152167302988.5268.4370226749268662682.stgit@dwillia2-desk3.amr.corp.intel.com> <152167305782.5268.13485258587227210521.stgit@dwillia2-desk3.amr.corp.intel.com> <20180329154035.lvsepjvt6vcplshw@quack2.suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Theodore Ts'o , linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org, david-FqsqvQoI3Ljby3iVrkZq2A@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-xfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Andreas Dilger , linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, hch-jcswGhMUV9g@public.gmane.org To: Jan Kara Return-path: Content-Disposition: inline In-Reply-To: <20180329154035.lvsepjvt6vcplshw-4I4JzKEfoa/jFM9bn6wA6Q@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-nvdimm-bounces-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org Sender: "Linux-nvdimm" List-Id: linux-ext4.vger.kernel.org On Thu, Mar 29, 2018 at 05:40:35PM +0200, Jan Kara wrote: > So ext4_direct_IO() for IS_DAX() files will just bail out. So could you > just provide ext4_dax_direct_IO() which will bail out and use it here? With > a similar comment as in xfs_vm_direct_IO() that open still needs this > method set... Thanks! In fact a common noop_direct_IO might make sense.