From: Richard Weinberger Subject: Re: vmalloc with GFP_NOFS Date: Tue, 24 Apr 2018 21:03:43 +0200 Message-ID: <3732370.1623zxSvNg@blindfold> References: <20180424162712.GL17484@dhcp22.suse.cz> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="nextPart26752059.sMrGihSObH" Content-Transfer-Encoding: 7Bit Cc: Kate Stewart , Trond Myklebust , LKML , linux-mm@kvack.org, Andreas Dilger , Boris Brezillon , cluster-devel@redhat.com, Marek Vasut , linux-ext4@vger.kernel.org, Cyrille Pitchen , Mikulas Patocka , linux-nfs@vger.kernel.org, Theodore Ts'o , Artem Bityutskiy , Adrian Hunter , Philippe Ombredanne , linux-mtd@lists.infradead.org, Brian Norris , David Woodhouse , Anna Schumaker To: Michal Hocko Return-path: In-Reply-To: <20180424162712.GL17484@dhcp22.suse.cz> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: cluster-devel-bounces@redhat.com Errors-To: cluster-devel-bounces@redhat.com List-Id: linux-ext4.vger.kernel.org This is a multi-part message in MIME format. --nextPart26752059.sMrGihSObH Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Am Dienstag, 24. April 2018, 18:27:12 CEST schrieb Michal Hocko: > fs/ubifs/debug.c This one is just for debugging. So, preallocating + locking would not hurt much. > fs/ubifs/lprops.c Ditto. > fs/ubifs/lpt_commit.c Here we use it also only in debugging mode and in one case for fatal error reporting. No hot paths. > fs/ubifs/orphan.c Also only for debugging. Getting rid of vmalloc with GFP_NOFS in UBIFS is no big problem. I can prepare a patch. Thanks, //richard --nextPart26752059.sMrGihSObH Content-Transfer-Encoding: 7Bit Content-Type: text/html; charset="us-ascii"

Am Dienstag, 24. April 2018, 18:27:12 CEST schrieb Michal Hocko:

> fs/ubifs/debug.c

This one is just for debugging.

So, preallocating + locking would not hurt much.

> fs/ubifs/lprops.c

Ditto.

> fs/ubifs/lpt_commit.c

Here we use it also only in debugging mode and in one case for

fatal error reporting.

No hot paths.

> fs/ubifs/orphan.c

Also only for debugging.

Getting rid of vmalloc with GFP_NOFS in UBIFS is no big problem.

I can prepare a patch.

Thanks,

//richard

--nextPart26752059.sMrGihSObH--