From: Ross Zwisler Subject: Re: [fstests PATCH 1/2] src/: fix up mmap() error checking Date: Fri, 22 Jun 2018 10:19:08 -0600 Message-ID: <20180622161908.GB29492@linux.intel.com> References: <20180620225147.12151-1-ross.zwisler@linux.intel.com> <20180622022838.GM2780@desktop> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Jan Kara , linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org, Dave Chinner , fstests-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Christoph Hellwig , linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Eryu Guan Return-path: Content-Disposition: inline In-Reply-To: <20180622022838.GM2780@desktop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-nvdimm-bounces-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org Sender: "Linux-nvdimm" List-Id: linux-ext4.vger.kernel.org On Fri, Jun 22, 2018 at 10:28:38AM +0800, Eryu Guan wrote: > On Wed, Jun 20, 2018 at 04:51:46PM -0600, Ross Zwisler wrote: > > I noticed that in some of my C tests in src/ I was incorrectly checking for > > mmap() failure by looking for NULL instead of MAP_FAILED. Fix those and > > clean up some places where we were testing against -1 (the actual value of > > MAP_FAILED) which was manually being cast to a pointer. > > > > Signed-off-by: Ross Zwisler > > BTW, I've applied this patch, no need to resend it in v2. Okay, thanks for letting me know.